Skip to content

[Bug]: make_trial_event_controller criteria for time columns allows "_time" to appear anywhere in column name #314

@felixp8

Description

@felixp8

What happened?

The logic in make_trial_event_controller to determine trial event columns checks for "_time" in column_name, which is weaker than column_name.endswith("_time"), the check used by nwbinspector for example. Unsure what the consensus standard is here but in my case a boolean column called "has_timeout" was included as an alignment field, so I think the stronger check would be better.

Steps to Reproduce

n/a

Traceback

n/a

Operating System

Linux

Python Version

3.10

Package Versions

nwbinspector==0.11.3

Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions