Skip to content

Commit 494e288

Browse files
authored
Fix issue with importlib-metadata on conda py37 (#1645)
1 parent 8f9af98 commit 494e288

File tree

2 files changed

+28
-12
lines changed

2 files changed

+28
-12
lines changed

.github/workflows/run_all_tests.yml

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -163,16 +163,20 @@ jobs:
163163
uses: conda-incubator/setup-miniconda@v2
164164
with:
165165
auto-update-conda: true
166-
auto-activate-base: true
167-
activate-environment: true
168166
python-version: ${{ matrix.python-ver }}
169167

170168
- name: Install build dependencies
171169
run: |
172170
conda config --set always_yes yes --set changeps1 no
173171
conda info
174-
conda install -c conda-forge tox
175-
conda list
172+
# the conda dependency resolution for tox under python 3.7 can install the wrong importlib_metadata
173+
conda install -c conda-forge tox "importlib_metadata>4"
174+
175+
- name: Conda reporting
176+
run: |
177+
conda info
178+
conda config --show-sources
179+
conda list --show-channel-urls
176180
177181
- name: Run tox tests
178182
run: |
@@ -272,10 +276,14 @@ jobs:
272276
run: |
273277
pip install matplotlib
274278
pip install -e .
275-
conda info
276-
conda list
277279
pip list
278280
281+
- name: Conda reporting
282+
run: |
283+
conda info
284+
conda config --show-sources
285+
conda list --show-channel-urls
286+
279287
- name: Run gallery ros3 tests
280288
run: |
281289
python test.py --example-ros3

.github/workflows/run_tests.yml

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -138,16 +138,20 @@ jobs:
138138
uses: conda-incubator/setup-miniconda@v2
139139
with:
140140
auto-update-conda: true
141-
auto-activate-base: true
142-
activate-environment: true
143141
python-version: ${{ matrix.python-ver }}
144142

145143
- name: Install build dependencies
146144
run: |
147145
conda config --set always_yes yes --set changeps1 no
148146
conda info
149-
conda install -c conda-forge tox
150-
conda list
147+
# the conda dependency resolution for tox under python 3.7 can install the wrong importlib_metadata
148+
conda install -c conda-forge tox "importlib_metadata>4"
149+
150+
- name: Conda reporting
151+
run: |
152+
conda info
153+
conda config --show-sources
154+
conda list --show-channel-urls
151155
152156
- name: Run tox tests
153157
run: |
@@ -242,10 +246,14 @@ jobs:
242246
run: |
243247
pip install matplotlib
244248
pip install -e .
245-
conda info
246-
conda list
247249
pip list
248250
251+
- name: Conda reporting
252+
run: |
253+
conda info
254+
conda config --show-sources
255+
conda list --show-channel-urls
256+
249257
- name: Run gallery ros3 tests
250258
run: |
251259
python test.py --example-ros3

0 commit comments

Comments
 (0)