Skip to content

Commit b1e4697

Browse files
authored
Merge pull request #1243 from NeurodataWithoutBorders/schema_2.2.5
2 parents c124687 + 13744d7 commit b1e4697

File tree

4 files changed

+288
-145
lines changed

4 files changed

+288
-145
lines changed

CHANGELOG.md

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,19 @@
11
# PyNWB Changelog
22

3+
## PyNWB 1.3.2 (June 1, 2020)
4+
5+
### Bug fixes:
6+
- Add support for nwb-schema 2.2.5. @rly (#1243)
7+
- This schema version fixes incorrect dims and shape for `ImagingPlane.origin_coords` and `ImagingPlane.grid_spacing`,
8+
and fixes incorrect dims for `TwoPhotonSeries.field_of_view`.
9+
310
## PyNWB 1.3.1 (May 28, 2020)
411

512
### Bug fixes:
613
- Fix bugged `Device` constructor. @rly (#1209)
714
- Fix link to code of conduct page in docs. @rly (#1229)
8-
- Fix docs for get_type_map. @oruebel (#1233)
9-
- Pass file object to parent when loading namespaces (#1242)
15+
- Fix docs for `get_type_map`. @oruebel (#1233)
16+
- Pass file object to parent when loading namespaces. @NileGraddis (#1242)
1017

1118
### Internal improvements:
1219
- Update CI to use supported MacOS version. @rly (#1211)
@@ -17,17 +24,15 @@
1724
- Inform which unit value is actually overwritten. @yarikoptic (#1219)
1825
- Do not print out logging.DEBUG statements to stdout for test.py. @rly (#1240)
1926
- Add support for nwb-schema 2.2.4. @rly (#1213)
20-
- Make `ImagingPlane.imaging_rate` optional. This moves the `imaging_rate` argument down the list of constructor
21-
arguments for `ImagingPlane.__init__`. This will break existing code that calls the constructor of
22-
`ImagingPlane` with at least 6 positional arguments, such that one positional argument matches `imaging_rate`.
27+
- Make `ImagingPlane.imaging_rate` optional. This moves the `imaging_rate` argument down the list of constructor arguments for `ImagingPlane.__init__`. This will break existing code that calls the constructor of `ImagingPlane` with at least 6 positional arguments, such that one positional argument matches `imaging_rate`.
2328

2429
## PyNWB 1.3.0 (Mar. 4, 2020)
2530

2631
### New features:
2732
- Add support for nwb-schema 2.2.2. @rly (#1146)
28-
- This is a large change. See the PR and schema release notes for more information: nwb-schema.readthedocs.io/en/latest/format_release_notes.html#march-2-2020
33+
- This is a large change. See the PR and [schema release notes](http://nwb-schema.readthedocs.io/en/latest/format_release_notes.html#march-2-2020) for more information.
2934
- Validate against most specific namespace. @t-b, @rly (#1094)
30-
- Replace 'ic_electrode' with 'icephys_electrode' in NWBFile. @oruebel (#1200)
35+
- Replace 'ic_electrode' with 'icephys_electrode' in `NWBFile`. @oruebel (#1200)
3136
- Integrate minor enhancements and bug fixes introduced in HDMF 1.6.0 and 1.6.1, including improved handling of namespaces that lack a version key,
3237

3338
### Internal improvements:
@@ -42,7 +47,7 @@
4247
- Fix unit testing output. @rly (#1158)
4348
- Fix copying files with Subject. @rly (#1171)
4449
- Add "unit" attribute back as an optional attribute in icephys classes. @rly (#1188)
45-
- Fix reported development status in setup.py. @rly (#1201)
50+
- Fix reported development status in `setup.py`. @rly (#1201)
4651

4752
## PyNWB 1.2.1 (Jan. 22, 2020)
4853

tests/integration/hdf5/test_ophys.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,11 @@ def setUpContainer(self):
3333
imaging_rate=300.,
3434
indicator='GFP',
3535
location='somewhere in the brain',
36-
reference_frame='unknown'
36+
reference_frame='unknown',
37+
origin_coords=[10, 20],
38+
origin_coords_unit='millimeters',
39+
grid_spacing=[0.001, 0.001],
40+
grid_spacing_unit='millimeters',
3741
)
3842

3943
def addContainer(self, nwbfile):

0 commit comments

Comments
 (0)