Skip to content

Commit cbf41c1

Browse files
authored
Update HDMF pin to 4.1.2 and shape error test
1 parent 801f92e commit cbf41c1

File tree

6 files changed

+10
-6
lines changed

6 files changed

+10
-6
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
### Changed
1515
- Change UI of documentation assistant to be an accordion that is always visible. @bendichter [#2124](https://github.com/NeurodataWithoutBorders/pynwb/pull/2124)
16+
- Updated minimum HDMF version to 4.1.2 and updated tests accordingly. @rly []()
1617

1718

1819
## PyNWB 3.1.2 (August 13, 2025)

environment-ros3.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ channels:
66
dependencies:
77
- python==3.13
88
- h5py==3.12.1
9-
- hdmf==4.1.0
9+
- hdmf==4.1.2
1010
- matplotlib==3.9.2
1111
- numpy==2.1.3
1212
- pandas==2.2.3

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ classifiers = [
3434
]
3535
dependencies = [
3636
"h5py>=3.2.0",
37-
"hdmf>=4.1.0,<5",
37+
"hdmf>=4.1.2,<5",
3838
"numpy>=1.24.0",
3939
"pandas>=1.2.0",
4040
"python-dateutil>=2.8.2",

requirements-min.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# minimum versions of package dependencies for installing PyNWB
22
h5py==3.2.0
3-
hdmf==4.1.1
3+
hdmf==4.1.2
44
numpy==1.24.0
55
pandas==1.2.0
66
python-dateutil==2.8.2

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# pinned dependencies to reproduce an entire development environment to use PyNWB
22
h5py==3.12.1
3-
hdmf==4.1.1
3+
hdmf==4.1.2
44
numpy==2.1.1; python_version > "3.9" # numpy 2.1+ is not compatible with py3.9
55
numpy==2.0.2; python_version == "3.9"
66
pandas==2.2.3

tests/unit/test_ecephys.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,11 @@ def test_link(self):
8686

8787
def test_invalid_data_shape(self):
8888
table, region = self._create_table_and_region()
89-
with self.assertRaisesWith(ValueError, ("ElectricalSeries.__init__: incorrect shape for 'data' (got '(2, 2, 2, "
90-
"2)', expected '((None,), (None, None), (None, None, None))')")):
89+
msg = (
90+
"ElectricalSeries.__init__: incorrect shape for data: got (2, 2, 2, 2), "
91+
"and expected (*,) or (*, *) or (*, *, *)"
92+
)
93+
with self.assertRaisesWith(ValueError, msg):
9194
ElectricalSeries(name='test_ts1', data=np.ones((2, 2, 2, 2)), electrodes=region,
9295
timestamps=[0.0, 0.1, 0.2, 0.3, 0.4, 0.5])
9396

0 commit comments

Comments
 (0)