-
Notifications
You must be signed in to change notification settings - Fork 90
Closed
Labels
category: enhancementimprovements of code or code behaviorimprovements of code or code behaviorpriority: highimpacts proper operation or use of feature important to most usersimpacts proper operation or use of feature important to most users
Description
What would you like to see added to PyNWB?
From making columns in DynamicTable expandable by default, the edge case of "named but untyped" types blocks full support of that feature. The current known types are ElectrodesTable and the bands table in DecompositionSeries. The reason this is an issue is that the shape definition is not being used from the untyped type but from the schema of DynamicTable.
Bands Table:
The schema defines the shape to be [None, 2]. We want the shape so that we don't override schema set values when making things expandable. In this case, We want the shape of the dataset to be written as [None, 2] and not [None, None], i.e., not expandable in dimensions that are defined not to be.
The fix is to create a type for Bands Table.
Is your feature request related to a problem?
Above
What solution would you like?
Above.
Do you have any interest in helping implement the feature?
Yes.
Code of Conduct
- I agree to follow this project's Code of Conduct
- Have you checked the Contributing document?
- Have you ensured this change was not already requested?
Metadata
Metadata
Assignees
Labels
category: enhancementimprovements of code or code behaviorimprovements of code or code behaviorpriority: highimpacts proper operation or use of feature important to most usersimpacts proper operation or use of feature important to most users