Skip to content

Add BaseImage and ExternalImage #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: nwb-schema-2.9.0
Choose a base branch
from
Open

Add BaseImage and ExternalImage #2079

wants to merge 5 commits into from

Conversation

rly
Copy link
Contributor

@rly rly commented May 10, 2025

Motivation

Fix #2042

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Copy link

codecov bot commented May 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.86%. Comparing base (f956fbb) to head (c803fb9).

Additional details and impacted files
@@                 Coverage Diff                  @@
##           nwb-schema-2.9.0    #2079      +/-   ##
====================================================
+ Coverage             94.83%   94.86%   +0.03%     
====================================================
  Files                    28       28              
  Lines                  2749     2767      +18     
  Branches                708      712       +4     
====================================================
+ Hits                   2607     2625      +18     
  Misses                   82       82              
  Partials                 60       60              
Flag Coverage Δ
integration 74.34% <100.00%> (+0.16%) ⬆️
unit 84.85% <92.30%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rly rly marked this pull request as ready for review May 10, 2025 08:20
@rly rly requested a review from oruebel May 10, 2025 08:20
@rly rly requested a review from stephprince May 12, 2025 16:23
Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but I think I am not following when something should inherit from BaseImage, Image, or ExternalImage. Should RGBImage, GrayscaleImage and RGBAImage also inherit from BaseImage now so that they can support ExternalImage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants