Skip to content

Fix DataTable's light-mode clash with the fixed-dark pagination-filters demo shell #810

Description

@Abidoyesimze

Summary

The demo page hardcodes bg-gray-900 with no dark:/light branch of its own, while DataTable renders bg-white dark:bg-slate-900/40. In light theme this produces a stark white table card floating inside an always-dark page shell, undermining the recent migration's goal of consistent dark-mode pairing.

Affected files

  • src/app/demo/pagination-filters/page.tsx
  • src/components/ui/DataTable.tsx

Tasks

  • Give the demo page shell proper light/dark variants instead of a hardcoded dark background, so DataTable's own theming reads correctly in both themes.

Acceptance criteria

  • Scope is limited to the files listed (or agreed alternatives in the PR).
  • Change is verifiable: tests, screenshots, or written QA steps in the PR.
  • No behavior regressions in related user flows.
  • No new duplicate abstractions without a one-line rationale in the PR.

Suggested labels

bug, css, responsive

Notes

Sourced from the 2026-08 round-4 follow-up audit of the frontend codebase at commit 201f5b0, run after the round-3 batch (#684-#743) was substantially resolved. Verified against current file content at time of writing.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Stellar WaveIssues in the Stellar wave programbugSomething isn't workingcssresponsive

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions