#147 サウンド追加エリアのテストケースを追加

Author: ienaga

src/js/controller/application/SoundArea/service/SoundAreaLoopCountFocusInEventService.test.ts

@@ -10,30 +10,23 @@ describe("SoundAreaLoopCountFocusInEventServiceTest", () =>
         input.style.cursor = "auto";
 
         let stopPropagation = false;
-        let preventDefault  = false;
         const eventMock = {
             "target": input,
             "stopPropagation": vi.fn(() =>
             {
                 stopPropagation = true;
             }),
-            "preventDefault": vi.fn(() =>
-            {
-                preventDefault = true;
-            })
         } as unknown as FocusEvent;
 
         $updateKeyLock(false);
         expect($useKeyboard()).toBe(false);
         expect(stopPropagation).toBe(false);
-        expect(preventDefault).toBe(false);
         expect(input.style.cursor).toBe("auto");
 
         execute(eventMock);
 
         expect($useKeyboard()).toBe(true);
         expect(stopPropagation).toBe(true);
-        expect(preventDefault).toBe(true);
         expect(input.style.cursor).toBe("");
     });
 });

src/js/controller/application/SoundArea/service/SoundAreaLoopCountFocusInEventService.ts

@@ -18,15 +18,14 @@ export const execute = (event: FocusEvent): void =>
         return ;
     }
 
-    // イベントの伝播を止める
-    event.stopPropagation();
-    event.preventDefault();
-
     // 入力モードをOnにする
     $updateKeyLock(true);
 
     // 入力中のelementをセット
     $setEditingElement(element);
 
+    // イベントの伝播を止める
+    event.stopPropagation();
+
     element.style.cursor = "";
 };

src/js/controller/application/SoundArea/service/SoundAreaLoopCountKeyPressEventService.test.ts

@@ -13,29 +13,22 @@ describe("SoundAreaLoopCountKeyPressEventServiceTest", () =>
             blur = true;
         });
 
-        let preventDefault = false;
         let stopPropagation = false;
         const eventMock = {
             "stopPropagation": () =>
             {
                 stopPropagation = true;
             },
-            "preventDefault": () =>
-            {
-                preventDefault = true;
-            },
             "key": "Enter",
             "currentTarget": div
         } as unknown as KeyboardEvent;
 
         expect(blur).toBe(false);
         expect(stopPropagation).toBe(false);
-        expect(preventDefault).toBe(false);
 
         execute(eventMock);
 
         expect(blur).toBe(true);
         expect(stopPropagation).toBe(true);
-        expect(preventDefault).toBe(true);
     });
 });

src/js/controller/application/SoundArea/service/SoundAreaLoopCountKeyPressEventService.ts

@@ -13,15 +13,14 @@ export const execute = (event: KeyboardEvent): void =>
         return ;
     }
 
-    // 親のイベントを終了
-    event.stopPropagation();
-    event.preventDefault();
-
     const element = event.currentTarget as HTMLElement;
     if (!element) {
         return ;
     }
 
+    // 親のイベントを終了
+    event.stopPropagation();
+
     // 入力終了
     element.blur();
 };

src/js/controller/application/SoundArea/service/SoundAreaLoopCountPointerOutEventService.ts

@@ -15,13 +15,13 @@ export const execute = (event: PointerEvent): void =>
         return ;
     }
 
-    event.stopPropagation();
-    event.preventDefault();
-
     const element = event.currentTarget as HTMLElement;
     if (!element) {
         return ;
     }
 
+    // イベントの伝播を停止
+    event.stopPropagation();
+
     element.style.cursor = "";
 };

src/js/controller/application/SoundArea/service/SoundAreaLoopCountPointerOverEventService.test.ts

@@ -8,26 +8,20 @@ describe("SoundAreaLoopCountPointerOverEventService Test", () =>
         const input = document.createElement("input");
 
         let stopPropagation = false;
-        let preventDefault  = false;
         const eventMock = {
             "stopPropagation": () =>
             {
                 stopPropagation = true;
             },
-            "preventDefault": () => {
-                preventDefault = true;
-            },
             "currentTarget": input
         } as unknown as PointerEvent;
 
         expect(stopPropagation).toBe(false);
-        expect(preventDefault).toBe(false);
         expect(input.style.cursor).toBe("");
 
         execute(eventMock);
 
         expect(stopPropagation).toBe(true);
-        expect(preventDefault).toBe(true);
         expect(input.style.cursor).toBe("ew-resize");
     });
 });

src/js/controller/application/SoundArea/service/SoundAreaLoopCountPointerOverEventService.ts

@@ -15,15 +15,14 @@ export const execute = (event: FocusEvent): void =>
         return ;
     }
 
-    // イベントの伝播を止める
-    event.stopPropagation();
-    event.preventDefault();
-
     // フォーカスを移動用に変更
     const element: HTMLElement | null = event.currentTarget as HTMLElement;
     if (!element) {
         return ;
     }
 
+    // イベントの伝播を止める
+    event.stopPropagation();
+
     element.style.cursor = "ew-resize";
 };

src/js/controller/application/SoundArea/service/SoundAreaVolumeFocusInEventService.test.ts

@@ -10,30 +10,23 @@ describe("SoundAreaVolumeFocusInEventServiceTest", () =>
         input.style.cursor = "pointer";
 
         let stopPropagation = false;
-        let preventDefault = false;
         const eventMock = {
             "stopPropagation": vi.fn(() =>
             {
                 stopPropagation = true;
             }),
-            "preventDefault": vi.fn(() =>
-            {
-                preventDefault = true;
-            }),
             "target": input
         } as unknown as FocusEvent;
 
         $updateKeyLock(false);
         expect($useKeyboard()).toBe(false);
         expect(stopPropagation).toBe(false);
-        expect(preventDefault).toBe(false);
         expect(input.style.cursor).toBe("pointer");
 
         execute(eventMock);
 
         expect($useKeyboard()).toBe(true);
         expect(stopPropagation).toBe(true);
-        expect(preventDefault).toBe(true);
         expect(input.style.cursor).toBe("");
     });
 });

src/js/controller/application/SoundArea/service/SoundAreaVolumeFocusInEventService.ts

@@ -18,15 +18,14 @@ export const execute = (event: FocusEvent): void =>
         return ;
     }
 
-    // イベントの伝播を止める
-    event.stopPropagation();
-    event.preventDefault();
-
     // 入力モードをOnにする
     $updateKeyLock(true);
 
     // 入力中のelementをセット
     $setEditingElement(element);
 
+    // イベントの伝播を止める
+    event.stopPropagation();
+
     element.style.cursor = "";
 };

src/js/controller/application/SoundArea/service/SoundAreaVolumeKeyPressEventService.test.ts

@@ -5,25 +5,18 @@ describe("SoundAreaVolumeKeyPressEventServiceTest", () =>
 {
     it("execute test", () =>
     {
-        let preventDefault = false;
         let stopPropagation = false;
         const eventMock = {
             "stopPropagation": () =>
             {
                 stopPropagation = true;
             },
-            "preventDefault": () =>
-            {
-                preventDefault = true;
-            },
             "key": "Enter",
             "currentTarget": document.createElement("div")
         } as unknown as KeyboardEvent;
 
         expect(stopPropagation).toBe(false);
-        expect(preventDefault).toBe(false);
         execute(eventMock);
         expect(stopPropagation).toBe(true);
-        expect(preventDefault).toBe(true);
     });
 });

src/js/controller/application/SoundArea/service/SoundAreaVolumeKeyPressEventService.ts

@@ -13,15 +13,14 @@ export const execute = (event: KeyboardEvent): void =>
         return ;
     }
 
-    // 親のイベントを終了
-    event.stopPropagation();
-    event.preventDefault();
-
     const element: HTMLElement | null = event.currentTarget as HTMLElement;
     if (!element) {
         return ;
     }
 
+    // 親のイベントを終了
+    event.stopPropagation();
+
     // 入力終了
     element.blur();
 };

src/js/controller/application/SoundArea/service/SoundAreaVolumePointerOutEventService.test.ts

@@ -9,26 +9,20 @@ describe("SoundAreaVolumePointerOutEventService Test", () =>
         input.style.cursor = "ew-resize";
 
         let stopPropagation = false;
-        let preventDefault  = false;
         const eventMock = {
             "stopPropagation": () =>
             {
                 stopPropagation = true;
             },
-            "preventDefault": () => {
-                preventDefault = true;
-            },
             "currentTarget": input
         } as unknown as PointerEvent;
 
         expect(stopPropagation).toBe(false);
-        expect(preventDefault).toBe(false);
         expect(input.style.cursor).toBe("ew-resize");
 
         execute(eventMock);
 
         expect(stopPropagation).toBe(true);
-        expect(preventDefault).toBe(true);
         expect(input.style.cursor).toBe("");
     });
 });

src/js/controller/application/SoundArea/service/SoundAreaVolumePointerOutEventService.ts

@@ -15,13 +15,13 @@ export const execute = (event: PointerEvent): void =>
         return ;
     }
 
-    event.stopPropagation();
-    event.preventDefault();
-
     const element: HTMLElement | null = event.currentTarget as HTMLElement;
     if (!element) {
         return ;
     }
 
+    // イベントの伝播を停止
+    event.stopPropagation();
+
     element.style.cursor = "";
 };

src/js/controller/application/SoundArea/service/SoundAreaVolumePointerOverEventService.test.ts

@@ -8,27 +8,20 @@ describe("SoundAreaVolumePointerOverEventService Test", () =>
         const input = document.createElement("input");
 
         let stopPropagation = false;
-        let preventDefault  = false;
         const eventMock = {
             "stopPropagation": vi.fn(() =>
             {
                 stopPropagation = true;
             }),
-            "preventDefault": vi.fn(() =>
-            {
-                preventDefault = true;
-            }),
             "currentTarget": input
         } as unknown as PointerEvent;
 
         expect(stopPropagation).toBe(false);
-        expect(preventDefault).toBe(false);
         expect(input.style.cursor).toBe("");
 
         execute(eventMock);
 
         expect(stopPropagation).toBe(true);
-        expect(preventDefault).toBe(true);
         expect(input.style.cursor).toBe("ew-resize");
     });
 });

src/js/controller/application/SoundArea/service/SoundAreaVolumePointerOverEventService.ts

@@ -15,15 +15,14 @@ export const execute = (event: FocusEvent): void =>
         return ;
     }
 
-    // イベントの伝播を止める
-    event.stopPropagation();
-    event.preventDefault();
-
     // フォーカスを移動用に変更
     const element = event.currentTarget as HTMLElement;
     if (!element) {
         return ;
     }
 
+    // イベントの伝播を止める
+    event.stopPropagation();
+
     element.style.cursor = "ew-resize";
 };

src/js/controller/application/SoundArea/usecase/SoundAreaLoopCountFocusOutEventUseCase.test.ts

@@ -24,24 +24,20 @@ describe("SoundAreaLoopCountFocusOutEventUseCase Test", () =>
         input.value = "1";
 
         let stopPropagation = false;
-        let preventDefault = false;
         const mockEvent = {
             "stopPropagation": vi.fn(() => { stopPropagation = true; }),
-            "preventDefault": vi.fn(() => { preventDefault = true; }),
             "currentTarget": input
         } as unknown as FocusEvent;
 
         $updateKeyLock(true);
         expect($useKeyboard()).toBe(true);
         expect(stopPropagation).toBe(false);
-        expect(preventDefault).toBe(false);
         expect(soundObject.loopCount).toBe(100);
 
         await execute(mockEvent);
 
         expect($useKeyboard()).toBe(false);
         expect(stopPropagation).toBe(true);
-        expect(preventDefault).toBe(true);
         expect(soundObject.loopCount).toBe(1);
     });
 });