Review: Deus Ex: Human Revolution

[ChemGuy1611]

Nexus Username

ChemBoy1

Extension URL

https://www.nexusmods.com/site/mods/1468

Game URL

https://www.nexusmods.com/deusexhumanrevolution

Existing Extension URL

NONE

New features

• Automatically downloads and install the exe patcher and ModHook to the game root folder.
• Installs .000 mods to "mods" folder.
• All other mods not described above will be installed to the game root folder.

Information

• I confirm the above is accurate

Packaging

• This extension is packaged correctly

Testing

• This game extension has been tested

Review Tasks

If a task fails, contact the author to request changes before continuing.

• Double-check for existing extension
• Is the extension packaged correctly?
• Does it install into Vortex?
• Does it correctly discover the game?
• Does it successfully install a mod?
• Does it successfully install a collection?
• Does the game run correctly with the mods installed? ​

When reviewed and passed, please complete the following tasks:

• Run the GitHub Actions to add to manifest
• Contact author
• Ask Community to enable the Vortex button for the game
• Update the #vortex-announcements channel on Discord

[IDCs]

Hey @ChemGuy1611 - thank you for your contribution!

There's a slight issue in the downloadHook function where you're using an undefined variable.

const fileTime = () => Number.parseInt(input.uploaded_time, 10); <--- input isn't defined

I'm assuming this was meant to be

const fileTime = (input) => Number.parseInt(input.uploaded_time, 10);

Let me know when this is fixd and I'll review again!

[ChemGuy1611]

I made the change. Just FYI, the installer does actually still work without triggering the catch block.

I'll do a search through my repo and make sure I add that input parameter for all those download functions.

[ChemGuy1611]

@IDCs - Also, thank you for making the time to review these extensions and provide helpful feedback. I know you are VERY busy with the major upgrades to Vortex, such as migrating to .NET 9.

Your time and effort is greatly appreciated!

[IDCs]

Thank you for your contribution!