feat(evm): Overwrite ERC20 metadata for stNIBI on Nibiru Testnet 2, and make the contract upgradeable. (#2381)

* wip!: save for now to implement this feature after
[feat(evm): Implement a state (ctx) serializable EVM StateDB to make asynchronous access more safe](#2378)

* revert precompile edits to do them in a future upgrade



* fix(evm): robustness improvments on metadata constructor

* fix(funtoken_from_erc20): add robustness checks against ERC20.symbols
with deterministic display denom during bank.Metadata generation

* fix(funtoken_from_erc20): pass through ERC20 name and symbol in raw form to allow bank.Metadata.Validate to protect against empty values

* feat(evm): Overwrite ERC20 metadata for stNIBI on Nibiru Testnet 2, and make the contract upgradeable.

* feat(evmtest): create an upgrade runner function and remove panics

Author: Unique-Divine

CHANGELOG.md

@@ -57,6 +57,8 @@ handling for NIBI via WNIBI.
 - [#2372](https://github.com/NibiruChain/nibiru/pull/2372) - feat(tokenfactory-cli): add CLI commands for set denom functions
 - [#2375](https://github.com/NibiruChain/nibiru/pull/2375) - feat(evm): Inject WNIBI.sol for non-mainnet networks in the v2.7.0 upgrade handler
 - [#2379](https://github.com/NibiruChain/nibiru/pull/2379) - fix(evm): disallow permissionless creation of FunToken mappings when tokens do not already have metadata.
+- [#2381](https://github.com/NibiruChain/nibiru/pull/2381) - feat(evm): Overwrite
+  ERC20 metadata for stNIBI on Nibiru Testnet 2, and make the contract upgradeable.
 
 ### Dependencies
 - Bump `base-x` from 3.0.10 to 3.0.11 ([#2355](https://github.com/NibiruChain/nibiru/pull/2355))

app/upgrades/v2_5_0/v2_5_0.go

@@ -41,9 +41,9 @@ var Upgrade = upgrades.Upgrade{
 			plan upgradetypes.Plan,
 			fromVM module.VersionMap,
 		) (module.VersionMap, error) {
-			err := UpgradeStNibiContractOnMainnet(nibiru, ctx, appconst.MAINNET_STNIBI_ADDR)
+			err := UpgradeStNibiEvmMetadata(nibiru, ctx, appconst.MAINNET_STNIBI_ADDR)
 			if err != nil {
-				panic(fmt.Errorf("v2.5.0 upgrade failure: %w", err))
+				return fromVM, fmt.Errorf("v2.5.0 upgrade failure: %w", err)
 			}
 
 			return mm.RunMigrations(ctx, cfg, fromVM)
@@ -52,7 +52,7 @@ var Upgrade = upgrades.Upgrade{
 	StoreUpgrades: storetypes.StoreUpgrades{},
 }
 
-func UpgradeStNibiContractOnMainnet(
+func UpgradeStNibiEvmMetadata(
 	keepers *keepers.PublicKeepers,
 	ctx sdk.Context,
 	// erc20Addr is the hex address of stNIBI on mainnet

app/upgrades/v2_5_0/v2_5_0_test.go

@@ -176,26 +176,28 @@ func (s *Suite) TestUpgrade() {
 	s.Run(fmt.Sprintf("Perform upgrade on stNIBI ERC20 address: %s", funtoken.Erc20Addr.Address), func() {
 		s.T().Log("IMPORTANT: Schedule the upgrade")
 		deps.EvmKeeper.Bank.StateDB = nil // IMPORTANT: make sure to clear the StateDB before running the upgrade
-		s.Require().True(deps.App.UpgradeKeeper.HasHandler(v2_5_0.Upgrade.UpgradeName))
+		s.Require().True(
+			deps.App.UpgradeKeeper.HasHandler(v2_5_0.Upgrade.UpgradeName),
+		)
 
-		beforeEvents := deps.Ctx.EventManager().Events()
-		err := v2_5_0.UpgradeStNibiContractOnMainnet(
+		eventsBeforeUpgrade := deps.Ctx.EventManager().Events()
+		err := v2_5_0.UpgradeStNibiEvmMetadata(
 			&deps.App.PublicKeepers, deps.Ctx, funtoken.Erc20Addr.Address,
 		)
 		s.Require().NoError(err)
-		upgradeEvents := testutil.FilterNewEvents(beforeEvents, deps.Ctx.EventManager().Events())
+		eventsInUpgrade := testutil.FilterNewEvents(eventsBeforeUpgrade, deps.Ctx.EventManager().Events())
 
-		err = testutil.AssertEventPresent(upgradeEvents,
+		err = testutil.AssertEventPresent(eventsInUpgrade,
 			gogoproto.MessageName(new(evm.EventContractDeployed)),
 		)
 		s.Require().NoError(err)
 
-		err = testutil.AssertEventPresent(upgradeEvents,
+		err = testutil.AssertEventPresent(eventsInUpgrade,
 			gogoproto.MessageName(new(tf.EventSetDenomMetadata)),
 		)
 		s.Require().NoError(err)
 
-		err = testutil.AssertEventPresent(upgradeEvents,
+		err = testutil.AssertEventPresent(eventsInUpgrade,
 			gogoproto.MessageName(new(evm.EventTxLog)),
 		)
 		s.Require().NoError(err)

app/upgrades/v2_7_0/testnet_stnibi.go

@@ -0,0 +1,63 @@
+package v2_7_0
+
+import (
+	"math/big"
+
+	sdk "github.com/cosmos/cosmos-sdk/types"
+	bank "github.com/cosmos/cosmos-sdk/x/bank/types"
+	gethcommon "github.com/ethereum/go-ethereum/common"
+
+	"github.com/NibiruChain/nibiru/v2/app/appconst"
+	"github.com/NibiruChain/nibiru/v2/app/keepers"
+	"github.com/NibiruChain/nibiru/v2/app/upgrades/v2_5_0"
+)
+
+// TESTNET_STNIBI_ADDR is the (real) hex address of stNIBI on testnet.
+// Produced from `nibid q evm funtoken | jq`
+// ```
+//
+//	{
+//	  "fun_token": {
+//	    "erc20_addr": "0xb6Ec473BeE85DC99B1B350510f592b80F034b5DD",
+//	    "bank_denom": "tf/nibi1keqw4dllsczlldd7pmzp25wyl04fw5anh3wxljhg4fjuqj9xnxuqa82rpg/ampNIBIT2",
+//	    "is_made_from_coin": true
+//	  }
+//	}
+//
+// ```
+var TESTNET_STNIBI_ADDR = gethcommon.HexToAddress("0xb6Ec473BeE85DC99B1B350510f592b80F034b5DD")
+
+// Queried from Testnet (ETH Chain ID 6911) on 2025-09-10.
+func OldTestnetStnibi() bank.Metadata {
+	stnibiDenomTestnet := "tf/nibi1keqw4dllsczlldd7pmzp25wyl04fw5anh3wxljhg4fjuqj9xnxuqa82rpg/ampNIBIT2"
+	return bank.Metadata{
+		Description: "",
+		DenomUnits: []*bank.DenomUnit{
+			{
+				Denom:    stnibiDenomTestnet,
+				Exponent: 0,
+			},
+		},
+		Base:    stnibiDenomTestnet,
+		Display: stnibiDenomTestnet,
+		Name:    stnibiDenomTestnet,
+		Symbol:  stnibiDenomTestnet,
+		URI:     "",
+		URIHash: "",
+	}
+}
+
+func UpgradeStNibiContractOnTestnet(
+	keepers *keepers.PublicKeepers,
+	ctx sdk.Context,
+) error {
+	// Only run this for testnet (6911).
+	if keepers.EvmKeeper.EthChainID(ctx).
+		Cmp(big.NewInt(appconst.ETH_CHAIN_ID_TESTNET_2)) != 0 {
+		return nil // Early return success
+	}
+
+	// This is safe to run because we've used this function to upgrade mainnet
+	// already.
+	return v2_5_0.UpgradeStNibiEvmMetadata(keepers, ctx, TESTNET_STNIBI_ADDR)
+}