Script broken?

[burnfeelings]

PS C:\Users\xxx\series\mediafire_rs\target\release> ./mdrs "https://www.mediafire.com/file/lgkkc4jvgonzddi/1983_1.mp4/file"
[------------------------------] 1/1 (100%) · Successful downloads 0 · Failed downloads 1
Failed downloads:
1983_1.mp4 · https://www.mediafire.com/file/lgkkc4jvgonzddi/1983_1.mp4/file

[NicKoehler]

Works fine on my end, did you used the last release?

[burnfeelings]

git clone https://github.com/NicKoehler/mediafire_rs.git
cd mediafire_rs
cargo build --release
cd target/release

and then I used with my link this
./mdrs "https://www.mediafire.com/file/examplefile12345/file.zip/file"

And it gave me that, so I'm unsure what's wrong on my end then.

[NicKoehler]

Can you try the precompiled executable in the releases?

[hnorkowski]

I tried to download this folder and every file there failed as well: https://www.mediafire.com/folder/9uiungtcuaunl/Automobilista_2_-_Thunderflash_Mods#2kmsjqrb4ej1l

[NicKoehler]

I tried to download this folder and every file there failed as well: https://www.mediafire.com/folder/9uiungtcuaunl/Automobilista_2_-_Thunderflash_Mods#2kmsjqrb4ej1l

• What is your OS?
• Did you tried the latest version?
• How did you installed? cargo, precompiled or compiled yourself?

[hnorkowski]

Windows 11, today installed using cargo. it looked to me that the latest release includes the latest commit but I can also try compiling it myself.

[NicKoehler]

Can you try the binaries from github releases?

[hnorkowski]

I would prefer not to run prebuilds from a pipeline job that I don't understand :D I also tested compiling it myself on Windows and in WSL but both fail

[hnorkowski]

Okay I executed it in a VM and it does exactly the same.

[NicKoehler]

Can you run cargo test on the project? I'm not reproducing this issue

[hnorkowski]

Sure. All tests succeed:

cargo test                                                                                                                                                                                                                                         24/04/25 15:02:00
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.27s
     Running unittests src\main.rs (target\debug\deps\mdrs-553b7ebac8dd092b.exe)

running 5 tests
test api::folder::tests::test_get_info ... ok
test api::folder::tests::test_get_folders_content ... ok
test api::folder::tests::test_get_files_content ... ok
test utils::tests::test_parse_download_link ... ok
test api::file::tests::test_get_info ... ok

test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.51s

[hnorkowski]

I added some debugging:

The download_file function returns an Err builder error.Then I added some more debug prints and then randomly some of the downloads succeeded. Maybe a race condition? I added a dbg! around src/downloads.rs starting in line 119 until before the ?

[hnorkowski]

I replaced all ? in download.rs with unwraps to see where it comes from:

thread 'tokio-runtime-worker' panicked at src\download.rs:128:52:
called `Result::unwrap()` on an `Err` value: reqwest::Error { kind: Builder, source: RelativeUrlWithoutBase }

EDIT: Ok the link parsing fails. It just returns a #

EDIT2: I stored the HTML content in a file and searched for downloadButton. the HREF is empty. Looks a bit like the page wasn't fully rendered. Maybe the link is inserted via JS or something? Weird thing is that it won't happen for you. Have you tried it with the link I provided?

EDIT3: maybe it has to do with cloudflare?
EDIT4: -m 1 does not change anything

Maybe using something like https://github.com/rust-headless-chrome/rust-headless-chrome would fix it?

[NicKoehler]

Probably using a browser would fix it, but I don't want to tie the script to an entire browser engine.

Cloudflare is our best bet, but without reproducing this issue on my part is difficult to solve. I suggest you to print the entire page body to see the actual HTML and post it here so we can try to figure it out

[KeithW0726]

yes, it's broken ..