Fixed import with FFmpeg and also fixed detection of FFmpeg/Gifski in settings window

Author: NickeManarin

ScreenToGif/Windows/Options.xaml.cs

@@ -1681,7 +1681,7 @@ private void CheckTools(bool ffmpeg = true, bool gifski = true)
             {
                 #region FFmpeg
 
-                if (Util.Other.IsFfmpegPresent(true, true))
+                if (Util.Other.IsFfmpegPresent(true, false))
                 {
                     var info = new FileInfo(Util.Other.AdjustPath(UserSettings.All.FfmpegLocation));
                     info.Refresh();
@@ -1702,7 +1702,7 @@ private void CheckTools(bool ffmpeg = true, bool gifski = true)
             {
                 #region Gifski
 
-                if (Util.Other.IsGifskiPresent(true, true))
+                if (Util.Other.IsGifskiPresent(true, false))
                 {
                     var info = new FileInfo(Util.Other.AdjustPath(UserSettings.All.GifskiLocation));
                     info.Refresh();

ScreenToGif/Windows/Other/VideoSource.xaml.cs

@@ -1,3 +1,4 @@
+using ScreenToGif.Domain.Enums;
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;
@@ -817,11 +818,12 @@ private async Task GetMultipleScreencaps()
 
             var info = new ProcessStartInfo(UserSettings.All.FfmpegLocation)
             {
-                Arguments = $" -i \"{VideoPath}\" -vsync 2 -progress pipe:1 -vf scale={VideoWidth}:{VideoHeight} -ss {start:hh\\:mm\\:ss\\.fff} -to {end:hh\\:mm\\:ss\\.fff} -hide_banner -c:v png -r {fps} -vframes {count} \"{path}\"",
+                Arguments = $" -i \"{VideoPath}\" -progress pipe:1 -vf scale={VideoWidth}:{VideoHeight} -ss {start:hh\\:mm\\:ss\\.fff} -to {end:hh\\:mm\\:ss\\.fff} -hide_banner -c:v png -r {fps} -vframes {count} \"{path}\"",
                 CreateNoWindow = true,
                 ErrorDialog = false,
                 UseShellExecute = false,
-                RedirectStandardOutput = true
+                RedirectStandardOutput = true,
+                RedirectStandardError = true
             };
 
             _process = new Process();
@@ -844,18 +846,18 @@ private async Task GetMultipleScreencaps()
                         break;
                 }
             };
-
-            _process.ErrorDataReceived += (sender, e) =>
-            {
-                if (!string.IsNullOrEmpty(e.Data))
-                    throw new Exception("Error while capturing frames with FFmpeg.") { HelpLink = $"Command:\n\r{info.Arguments}\n\rResult:\n\r{e.Data}" };
-            };
-
+            
             _process.StartInfo = info;
             _process.Start();
             _process.BeginOutputReadLine();
-
+            
             await _process.WaitForExitAsync();
+
+            var error = await _process?.StandardError?.ReadToEndAsync();
+
+            if (!string.IsNullOrWhiteSpace(error))
+                throw new Exception("Error while capturing frames with FFmpeg.") { HelpLink = $"Command:\n\r{info.Arguments}\n\rResult:\n\r{error}" };
+
         }
         catch (Exception e)
         {