Treewide: Apply dicoding advice on submission 2

* ApiConfig
  Only use logging interceptor while in debug build

* Adapter (Api or Local)
  Change variable to "_" when it's not use on adapter
  use declaration of "with(binding)" to avoid loop written of binding

* Repository
  Re-order companion object into bottom line of the code

* SplashScreen
  Re-declare constant value for timer on companion object

Also include cleanup code

....

Author: Nicklas373

app/src/main/java/com/dicoding/moviecatalog/activity/SplashScreenActivity.kt

@@ -23,6 +23,10 @@ class SplashScreenActivity : AppCompatActivity() {
             val intent = Intent(this, MainActivity::class.java)
             startActivity(intent)
             finish()
-        }, 3000)
+        }, delayMill.toLong())
+    }
+
+    companion object {
+        const val delayMill = 3000
     }
 }

app/src/main/java/com/dicoding/moviecatalog/adapter/CompaniesMovieAdapter.kt

@@ -27,7 +27,7 @@ class CompaniesMovieAdapter(private val listCompanies: ArrayList<ProductionCompa
 
     override fun onBindViewHolder(holder: ListViewHolder, position: Int) {
         with(holder) {
-            val (logo, name, id, origin) = listCompanies[position]
+            val (logo, name, _, origin) = listCompanies[position]
             val productionImage =
                 itemView.resources.getString(R.string.movieDb_static_image) + logo
             binding.nameCompaniesTxt.text = name

app/src/main/java/com/dicoding/moviecatalog/adapter/SectionPagerAdapter.kt

@@ -24,9 +24,9 @@ class SectionPagerAdapter(private val mContext: Context, fm: FragmentManager) :
             else -> Fragment()
         }
 
-    override fun getPageTitle(position: Int): CharSequence? =
+    override fun getPageTitle(position: Int): CharSequence =
         mContext.resources.getString(TAB_TITLES[position])
 
-    override fun getCount(): Int = 2
+    override fun getCount(): Int = TAB_TITLES.size
 
 }

app/src/main/java/com/dicoding/moviecatalog/adapter/api/MovieApiAdapter.kt

@@ -32,15 +32,17 @@ class MovieApiAdapter(private val listMovieApi: ArrayList<MovieListResponse>) :
 
     override fun onBindViewHolder(holder: ListViewHolder, position: Int) {
         with(holder) {
-            val (movieOverview, movieOriginalLanguage, movieRevenue, movieOriginalTitle, movieReleaseDate, moviePopularity, movieVoteAverage, movieId, movieTitle, moviePosterPath) = listMovieApi[position]
+            val (_, _, _, movieOriginalTitle, movieDate, _, movieVoteAverage, movieId, _, moviePosterPath) = listMovieApi[position]
             val movieImage =
                 itemView.context.getString(R.string.movieDb_static_image) + moviePosterPath
-            val releaseDate = inlineVariable.setReleaseDate(movieReleaseDate)
-            binding.movieTitle.text = movieOriginalTitle
-            binding.movieReleaseDate.text = releaseDate
-            binding.movieRatingText.text = movieVoteAverage.toString()
-            binding.separateRatingText.visibility = View.GONE
-            binding.movieDurationText.visibility = View.GONE
+            val releaseDate = inlineVariable.setReleaseDate(movieDate)
+            with(binding) {
+                movieTitle.text = movieOriginalTitle
+                movieReleaseDate.text = releaseDate
+                movieRatingText.text = movieVoteAverage.toString()
+                separateRatingText.visibility = View.GONE
+                movieDurationText.visibility = View.GONE
+            }
             Glide.with(itemView.context)
                 .load(movieImage)
                 .apply(

app/src/main/java/com/dicoding/moviecatalog/adapter/api/MovieGenreApiAdapter.kt

@@ -26,7 +26,7 @@ class MovieGenreApiAdapter(private val listMovieApi: ArrayList<MovieGenreListRes
 
     override fun onBindViewHolder(holder: ListViewHolder, position: Int) {
         with(holder) {
-            val (movieId, movieName) = listMovieApi[position]
+            val (_, movieName) = listMovieApi[position]
             binding.movieGenreText.text = movieName
             genreColoringApi(holder, movieName)
             if (movieName == science) {

app/src/main/java/com/dicoding/moviecatalog/adapter/api/TvShowApiAdapter.kt

@@ -33,15 +33,17 @@ class TvShowApiAdapter(private val listTvShowApi: ArrayList<TvShowListResponse>)
 
     override fun onBindViewHolder(holder: ListViewHolder, position: Int) {
         with(holder) {
-            val (FirstAirDate, Id, Name, Episode, Seasons, Language, Overview, Poster, Vote, Popularity) = listTvShowApi[position]
+            val (FirstAirDate, Id, Name, _, _, _, _, Poster, Vote, _) = listTvShowApi[position]
             val tvShowImage =
                 itemView.context.getString(R.string.movieDb_static_image) + Poster
             val releaseDate = inlineVariable.setReleaseDate(FirstAirDate)
-            binding.tvshowTitle.text = Name
-            binding.tvshowReleaseDate.text = releaseDate
-            binding.tvshowRatingText.text = Vote.toString()
-            binding.separateRatingText.visibility = View.GONE
-            binding.tvshowDurationText.visibility = View.GONE
+            with(binding) {
+                tvshowTitle.text = Name
+                tvshowReleaseDate.text = releaseDate
+                tvshowRatingText.text = Vote.toString()
+                separateRatingText.visibility = View.GONE
+                tvshowDurationText.visibility = View.GONE
+            }
             Glide.with(itemView.context)
                 .load(tvShowImage)
                 .apply(

app/src/main/java/com/dicoding/moviecatalog/adapter/api/TvShowGenreApiAdapter.kt

@@ -26,7 +26,7 @@ class TvShowGenreApiAdapter(private val listTvShowApi: ArrayList<TvShowGenreList
 
     override fun onBindViewHolder(holder: ListViewHolder, position: Int) {
         with(holder) {
-            val (movieId, movieName) = listTvShowApi[position]
+            val (_, movieName) = listTvShowApi[position]
             binding.movieGenreText.text = movieName
             genreColoringApi(holder, movieName)
             if (movieName == science) {

app/src/main/java/com/dicoding/moviecatalog/adapter/local/TvShowAdapter.kt

@@ -12,10 +12,6 @@ import com.dicoding.moviecatalog.activity.DetailShowActivity
 import com.dicoding.moviecatalog.data.source.remote.response.tvshow.TvShowListResponse
 import com.dicoding.moviecatalog.databinding.ItemsTvShowBinding
 import com.dicoding.moviecatalog.utils.InlineVariable
-import java.text.DateFormat
-import java.text.SimpleDateFormat
-import java.util.*
-import kotlin.collections.ArrayList
 
 class TvShowAdapter :
     RecyclerView.Adapter<TvShowAdapter.TvShowViewHolder>() {

app/src/main/java/com/dicoding/moviecatalog/api/ApiConfig.kt

@@ -1,5 +1,6 @@
 package com.dicoding.moviecatalog.api
 
+import com.dicoding.moviecatalog.BuildConfig
 import okhttp3.OkHttpClient
 import okhttp3.logging.HttpLoggingInterceptor
 import retrofit2.Retrofit
@@ -8,8 +9,11 @@ import retrofit2.converter.gson.GsonConverterFactory
 class ApiConfig {
     companion object {
         fun getApiService(): ApiService {
-            val loggingInterceptor =
+            val loggingInterceptor = if (BuildConfig.DEBUG) {
                 HttpLoggingInterceptor().setLevel(HttpLoggingInterceptor.Level.BODY)
+            } else {
+                HttpLoggingInterceptor().setLevel(HttpLoggingInterceptor.Level.NONE)
+            }
             val client = OkHttpClient.Builder()
                 .addInterceptor(loggingInterceptor)
                 .build()

app/src/main/java/com/dicoding/moviecatalog/data/source/Repository.kt

@@ -22,15 +22,6 @@ import retrofit2.Response
 class Repository private constructor(private val remoteDataSource: RemoteDataSource) :
     DataSource {
 
-    companion object {
-        @Volatile
-        private var instance: Repository? = null
-        fun getInstance(remoteData: RemoteDataSource): Repository =
-            instance ?: synchronized(this) {
-                instance ?: Repository(remoteData).apply { instance = this }
-            }
-    }
-
     override fun getAllMovies(): MutableLiveData<ArrayList<MovieListResponse>> {
         val resultAllMovies = MutableLiveData<ArrayList<MovieListResponse>>()
         remoteDataSource.getAllMovies(object : RemoteDataSource.LoadMoviesCallback {
@@ -295,4 +286,13 @@ class Repository private constructor(private val remoteDataSource: RemoteDataSou
         })
         return resultGenreTvShowApi
     }
+
+    companion object {
+        @Volatile
+        private var instance: Repository? = null
+        fun getInstance(remoteData: RemoteDataSource): Repository =
+            instance ?: synchronized(this) {
+                instance ?: Repository(remoteData).apply { instance = this }
+            }
+    }
 }