Unit Test: Implement several missing test

Nicklas373 · Nicklas373 · commit 897b73d49c89 · 2022-02-06T14:10:28.000+07:00
After submission application, my submission was rejected due missing some of test on Unit Test..

- DetailViewModelTest.kt
* Adding test for checking each data that was grab from repo was match with local data

- RepositoryTest.kt
* Adding test for checking each data that was grab from repo was match with local data (For detail movie and tv show)
* Adding test method for get and update favorite movie and tv show

- FakeRepositoryTest.kt
* Reflect changes after adding test on RepositoryTest.kt

- CatalogDatabase.kt
* Reflect changes after adding test on RepositoryTest.kt
diff --git a/app/src/main/java/com/dicoding/moviecatalog/utils/CatalogDatabase.kt b/app/src/main/java/com/dicoding/moviecatalog/utils/CatalogDatabase.kt
@@ -307,4 +307,64 @@ object CatalogDatabase {
 
         return tvShow
     }
+
+    fun generateSusMovieLocal(): List<MovieDetailEntity> {
+
+        val susMovie = ArrayList<MovieDetailEntity>()
+
+        susMovie.add(
+            MovieDetailEntity(
+                "Seasoned musician Jackson Maine discovers — and falls in love with — struggling artist Ally. She has just about given up on her dream to make it big as a singer — until Jack coaxes her into the spotlight. But even as Ally's career takes off, the personal side of their relationship is breaking down, as Jack fights an ongoing battle with his own internal demons.",
+                "en",
+                "A Star Is Born",
+                "Drama",
+                "Romance",
+                433888866,
+                "2018-10-03",
+                48.76,
+                7.5,
+                332562,
+                "A Star Is Born",
+                "/wrFpXMNBRj2PBiN4Z5kix51XaIZ.jpg",
+                "Thunder Road",
+                "22 & Green",
+                "/cCzCClIzIh81Fa79hpW5nXoUsHK.png",
+                "null",
+                "US",
+                "US",
+            )
+        )
+
+        return susMovie
+    }
+
+    fun generateSusTvShowLocal(): List<TvShowDetailEntity> {
+
+        val susTvShow = ArrayList<TvShowDetailEntity>()
+
+        susTvShow.add(
+            TvShowDetailEntity(
+                "2012-10-10",
+                1412,
+                "Arrow",
+                170,
+                8,
+                "en",
+                "Spoiled billionaire playboy Oliver Queen is missing and presumed dead when his yacht is lost at sea. He returns five years later a changed man, determined to clean up the city as a hooded vigilante armed with a bow.",
+                "/gKG5QGz5Ngf8fgWpBsWtlg5L2SF.jpg",
+                6.7,
+                "321.082",
+                "Crime",
+                "Drama",
+                "Berlanti Productions",
+                "DC Entertainment",
+                "/3e294jszfE6cE8TOogmj0zNd6pL.png",
+                "/2Tc1P3Ac8M479naPp1kYT3izLS5.png",
+                "US",
+                "US",
+            )
+        )
+
+        return susTvShow
+    }
 }
diff --git a/app/src/test/java/com/dicoding/moviecatalog/viewmodel/activity/DetailViewModelTest.kt b/app/src/test/java/com/dicoding/moviecatalog/viewmodel/activity/DetailViewModelTest.kt
@@ -11,6 +11,8 @@ import com.dicoding.moviecatalog.viewmodel.DetailViewModel
 import com.dicoding.moviecatalog.vo.Resource
 import com.nhaarman.mockitokotlin2.verify
 import com.nhaarman.mockitokotlin2.verifyNoMoreInteractions
+import org.junit.Assert.assertEquals
+import org.junit.Assert.assertNotNull
 import org.junit.Before
 import org.junit.Rule
 import org.junit.Test
@@ -65,11 +67,30 @@ class DetailViewModelTest {
     fun getMovie() {
         val dummyDetailMovie = Resource.success(CatalogDatabase.generateSelectedMovieLocal())
         val movie = MutableLiveData<Resource<MovieDetailEntity>>()
+
         movie.value = dummyDetailMovie
 
         `when`(movieRepository.getSelectedMovies(movieId)).thenReturn(movie)
-
         viewModel.nGetSelectedMovie(movieId)
+        val movieEntity = viewModel.nGetSusMovie().value?.data
+
+        assertNotNull(movieEntity)
+        assertEquals(dummyMovie.movieId, movieEntity?.movieId)
+        assertEquals(dummyMovie.title, movieEntity?.title)
+        assertEquals(dummyMovie.overview, movieEntity?.overview)
+        assertEquals(dummyMovie.revenue, movieEntity?.revenue)
+        assertEquals(dummyMovie.releaseDate, movieEntity?.releaseDate)
+        assertEquals(dummyMovie.originalLanguage, movieEntity?.originalLanguage)
+        assertEquals(dummyMovie.posterPath, movieEntity?.posterPath)
+        movieEntity?.popularity?.let { assertEquals(dummyMovie.popularity, it, 0.0001) }
+        movieEntity?.voteAverage?.let { assertEquals(dummyMovie.voteAverage, it, 0.0001) }
+        assertEquals(dummyMovie.compName_1, movieEntity?.compName_1)
+        assertEquals(dummyMovie.compName_2, movieEntity?.compName_2)
+        assertEquals(dummyMovie.compOrigin_1, movieEntity?.compOrigin_1)
+        assertEquals(dummyMovie.compOrigin_2, movieEntity?.compOrigin_2)
+        assertEquals(dummyMovie.compLogo_1, movieEntity?.compLogo_1)
+        assertEquals(dummyMovie.compLogo_2, movieEntity?.compLogo_2)
+
         viewModel.nGetSusMovie().observeForever(movieObserver)
         verify(movieObserver).onChanged(dummyDetailMovie)
     }
@@ -81,8 +102,26 @@ class DetailViewModelTest {
         tvShow.value = dummyDetailTvShow
 
         `when`(movieRepository.getSelectedTvShow(tvShowId)).thenReturn(tvShow)
-
         viewModel.nGetSelectedTvShow(tvShowId)
+        val tvShowEntity = viewModel.nGetSusTvShow().value?.data
+
+        assertNotNull(tvShowEntity)
+        assertEquals(dummyTvShow.tvShowId, tvShowEntity?.tvShowId)
+        assertEquals(dummyTvShow.tvShowName, tvShowEntity?.tvShowName)
+        assertEquals(dummyTvShow.tvShowOverview, tvShowEntity?.tvShowOverview)
+        assertEquals(dummyTvShow.tvShowFirstAirDate, tvShowEntity?.tvShowFirstAirDate)
+        assertEquals(dummyTvShow.tvShowEpisodes, tvShowEntity?.tvShowEpisodes)
+        assertEquals(dummyTvShow.tvShowSeasons, tvShowEntity?.tvShowSeasons)
+        assertEquals(dummyTvShow.tvShowLanguage, tvShowEntity?.tvShowLanguage)
+        tvShowEntity?.tvShowVote?.let { assertEquals(dummyTvShow.tvShowVote, it, 0.0001) }
+        assertEquals(dummyTvShow.tvShowPopularity, tvShowEntity?.tvShowPopularity)
+        assertEquals(dummyTvShow.compName_1, tvShowEntity?.compName_1)
+        assertEquals(dummyTvShow.compName_2, tvShowEntity?.compName_2)
+        assertEquals(dummyTvShow.compOrigin_1, tvShowEntity?.compOrigin_1)
+        assertEquals(dummyTvShow.compOrigin_2, tvShowEntity?.compOrigin_2)
+        assertEquals(dummyTvShow.compLogo_1, tvShowEntity?.compLogo_1)
+        assertEquals(dummyTvShow.compLogo_2, tvShowEntity?.compLogo_2)
+
         viewModel.nGetSusTvShow().observeForever(tvShowObserver)
         verify(tvShowObserver).onChanged(dummyDetailTvShow)
     }
diff --git a/app/src/test/java/com/dicoding/moviecatalog/viewmodel/data/FakeRepositoryTest.kt b/app/src/test/java/com/dicoding/moviecatalog/viewmodel/data/FakeRepositoryTest.kt
@@ -146,9 +146,7 @@ class FakeRepositoryTest(
     }
 
     override fun updateFavMovies(movie: MovieDetailEntity, isSus: Boolean) {
-        appExecutors.diskIO().execute {
-            localDataSource.updateFavMovies(movie, isSus)
-        }
+        localDataSource.updateFavMovies(movie, isSus)
     }
 
     override fun getAllTvShow(
@@ -274,8 +272,6 @@ class FakeRepositoryTest(
     }
 
     override fun updateFavTvShow(tvShow: TvShowDetailEntity, isSus: Boolean) {
-        appExecutors.diskIO().execute {
             localDataSource.updateFavTvShow(tvShow, isSus)
-        }
     }
 }
diff --git a/app/src/test/java/com/dicoding/moviecatalog/viewmodel/data/RepositoryTest.kt b/app/src/test/java/com/dicoding/moviecatalog/viewmodel/data/RepositoryTest.kt
@@ -1,17 +1,22 @@
 package com.dicoding.moviecatalog.viewmodel.data
 
 import androidx.arch.core.executor.testing.InstantTaskExecutorRule
+import androidx.lifecycle.MutableLiveData
 import androidx.paging.DataSource
 import com.dicoding.moviecatalog.data.source.local.LocalDataSource
+import com.dicoding.moviecatalog.data.source.local.entity.movie.MovieDetailEntity
 import com.dicoding.moviecatalog.data.source.local.entity.movie.MovieListEntity
+import com.dicoding.moviecatalog.data.source.local.entity.tvshow.TvShowDetailEntity
 import com.dicoding.moviecatalog.data.source.local.entity.tvshow.TvShowListEntity
 import com.dicoding.moviecatalog.data.source.remote.RemoteDataSource
 import com.dicoding.moviecatalog.utils.AppExecutors
 import com.dicoding.moviecatalog.utils.CatalogDatabase
 import com.dicoding.moviecatalog.utils.SortUtils.NEWEST
+import com.dicoding.moviecatalog.viewmodel.utils.LiveDataTestUtil
 import com.dicoding.moviecatalog.viewmodel.utils.PagedListUtil
 import com.dicoding.moviecatalog.vo.Resource
 import com.nhaarman.mockitokotlin2.verify
+import com.nhaarman.mockitokotlin2.verifyNoMoreInteractions
 import org.junit.Assert.assertEquals
 import org.junit.Assert.assertNotNull
 import org.junit.Rule
@@ -34,6 +39,12 @@ class RepositoryTest {
         CatalogDatabase.generateMovieLocal()
     private val tvShowResponses =
         CatalogDatabase.generateTvShowLocal()
+    private val movieSelected = CatalogDatabase.generateSelectedMovieLocal()
+    private val tvShowSelected = CatalogDatabase.generateSelectedTvShowLocal()
+    private val susMovie = CatalogDatabase.generateSusMovieLocal()
+    private val susTvShow = CatalogDatabase.generateSusTvShowLocal()
+    private val movieId = movieSelected.movieId
+    private val tvShowId = tvShowSelected.tvShowId
 
     private val movieListId = "8174952"
     private val tvShowListId = "8174957"
@@ -51,6 +62,65 @@ class RepositoryTest {
         assertEquals(movieResponses.size.toLong(), movieEntities.data?.size?.toLong())
     }
 
+    @Test
+    fun getDetailMovie() {
+        val dummyDetailMovie = MutableLiveData<MovieDetailEntity>()
+        dummyDetailMovie.value = CatalogDatabase.generateSelectedMovieLocal()
+        `when`(local.getSelectedMovies(movieId)).thenReturn(dummyDetailMovie)
+
+        val movieDetailEntity = LiveDataTestUtil.getValue(fakeRepository.getSelectedMovies(movieId))
+        verify(local).getSelectedMovies(movieId)
+        assertNotNull(movieDetailEntity)
+        assertEquals(movieSelected.movieId, movieDetailEntity.data?.movieId)
+        assertEquals(movieSelected.title, movieDetailEntity.data?.title)
+        assertEquals(movieSelected.overview, movieDetailEntity.data?.overview)
+        assertEquals(movieSelected.revenue, movieDetailEntity.data?.revenue)
+        assertEquals(movieSelected.releaseDate, movieDetailEntity.data?.releaseDate)
+        assertEquals(movieSelected.originalLanguage, movieDetailEntity.data?.originalLanguage)
+        assertEquals(movieSelected.posterPath, movieDetailEntity.data?.posterPath)
+        movieDetailEntity.data?.popularity?.let {
+            assertEquals(
+                movieSelected.popularity,
+                it,
+                0.0001
+            )
+        }
+        movieDetailEntity.data?.voteAverage?.let {
+            assertEquals(
+                movieSelected.voteAverage,
+                it,
+                0.0001
+            )
+        }
+        assertEquals(movieSelected.compName_1, movieDetailEntity.data?.compName_1)
+        assertEquals(movieSelected.compName_2, movieDetailEntity.data?.compName_2)
+        assertEquals(movieSelected.compOrigin_1, movieDetailEntity.data?.compOrigin_1)
+        assertEquals(movieSelected.compOrigin_2, movieDetailEntity.data?.compOrigin_2)
+        assertEquals(movieSelected.compLogo_1, movieDetailEntity.data?.compLogo_1)
+        assertEquals(movieSelected.compLogo_2, movieDetailEntity.data?.compLogo_2)
+    }
+
+    @Test
+    fun updateFavoriteMovie() {
+        fakeRepository.updateFavMovies(CatalogDatabase.generateSelectedMovieLocal(), true)
+        verify(local).updateFavMovies(CatalogDatabase.generateSelectedMovieLocal(), true)
+        verifyNoMoreInteractions(local)
+    }
+
+    @Test
+    fun getFavoriteMovie() {
+        val dataSourceFactory =
+            mock(DataSource.Factory::class.java) as DataSource.Factory<Int, MovieDetailEntity>
+        `when`(local.getFavMovies(NEWEST)).thenReturn(dataSourceFactory)
+        fakeRepository.getFavoriteMovies(NEWEST)
+
+        val movieSusEntities =
+            Resource.success(PagedListUtil.mockPagedList(CatalogDatabase.generateSelectedFavMovie()))
+        verify(local).getFavMovies(NEWEST)
+        assertNotNull(movieSusEntities)
+        assertEquals(susMovie.size, movieSusEntities.data?.size)
+    }
+
     @Test
     fun getAllTvShow() {
         val dataSourceFactory =
@@ -63,4 +133,57 @@ class RepositoryTest {
         assertNotNull(tvShowEntities.data)
         assertEquals(tvShowResponses.size.toLong(), tvShowEntities.data?.size?.toLong())
     }
+
+    @Test
+    fun getDetailTvShow() {
+        val dummyDetailTvShow = MutableLiveData<TvShowDetailEntity>()
+        dummyDetailTvShow.value = CatalogDatabase.generateSelectedTvShowLocal()
+        `when`(local.getSelectedTvShow(tvShowId)).thenReturn(dummyDetailTvShow)
+
+        val tvShowDetailEntity =
+            LiveDataTestUtil.getValue(fakeRepository.getSelectedTvShow(tvShowId))
+        verify(local).getSelectedTvShow(tvShowId)
+        assertNotNull(tvShowDetailEntity)
+        assertEquals(tvShowSelected.tvShowId, tvShowDetailEntity.data?.tvShowId)
+        assertEquals(tvShowSelected.tvShowName, tvShowDetailEntity.data?.tvShowName)
+        assertEquals(tvShowSelected.tvShowOverview, tvShowDetailEntity.data?.tvShowOverview)
+        assertEquals(tvShowSelected.tvShowFirstAirDate, tvShowDetailEntity.data?.tvShowFirstAirDate)
+        assertEquals(tvShowSelected.tvShowEpisodes, tvShowDetailEntity.data?.tvShowEpisodes)
+        assertEquals(tvShowSelected.tvShowSeasons, tvShowDetailEntity.data?.tvShowSeasons)
+        assertEquals(tvShowSelected.tvShowLanguage, tvShowDetailEntity.data?.tvShowLanguage)
+        tvShowDetailEntity.data?.tvShowVote?.let {
+            assertEquals(
+                tvShowSelected.tvShowVote,
+                it,
+                0.0001
+            )
+        }
+        assertEquals(tvShowSelected.compName_1, tvShowDetailEntity.data?.compName_1)
+        assertEquals(tvShowSelected.compName_2, tvShowDetailEntity.data?.compName_2)
+        assertEquals(tvShowSelected.compOrigin_1, tvShowDetailEntity.data?.compOrigin_1)
+        assertEquals(tvShowSelected.compOrigin_2, tvShowDetailEntity.data?.compOrigin_2)
+        assertEquals(tvShowSelected.compLogo_1, tvShowDetailEntity.data?.compLogo_1)
+        assertEquals(tvShowSelected.compLogo_2, tvShowDetailEntity.data?.compLogo_2)
+    }
+
+    @Test
+    fun updateFavoriteTvShow() {
+        fakeRepository.updateFavTvShow(CatalogDatabase.generateSelectedTvShowLocal(), true)
+        verify(local).updateFavTvShow(CatalogDatabase.generateSelectedTvShowLocal(), true)
+        verifyNoMoreInteractions(local)
+    }
+
+    @Test
+    fun getFavoriteTvShow() {
+        val dataSourceFactory =
+            mock(DataSource.Factory::class.java) as DataSource.Factory<Int, TvShowDetailEntity>
+        `when`(local.getFavTvShow(NEWEST)).thenReturn(dataSourceFactory)
+        fakeRepository.getFavoriteTvShow(NEWEST)
+
+        val tvShowSusEntities =
+            Resource.success(PagedListUtil.mockPagedList(CatalogDatabase.generateSelectedFavTvShow()))
+        verify(local).getFavTvShow(NEWEST)
+        assertNotNull(tvShowSusEntities)
+        assertEquals(susTvShow.size, tvShowSusEntities.data?.size)
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -146,9 +146,7 @@ class FakeRepositoryTest(`
`146`	`146`	`}`
`147`	`147`
`148`	`148`	`override fun updateFavMovies(movie: MovieDetailEntity, isSus: Boolean) {`
`149`		`- appExecutors.diskIO().execute {`
`150`		`- localDataSource.updateFavMovies(movie, isSus)`
`151`		`- }`
	`149`	`+ localDataSource.updateFavMovies(movie, isSus)`
`152`	`150`	`}`
`153`	`151`
`154`	`152`	`override fun getAllTvShow(`
`@@ -274,8 +272,6 @@ class FakeRepositoryTest(`
`274`	`272`	`}`
`275`	`273`
`276`	`274`	`override fun updateFavTvShow(tvShow: TvShowDetailEntity, isSus: Boolean) {`
`277`		`- appExecutors.diskIO().execute {`
`278`	`275`	`localDataSource.updateFavTvShow(tvShow, isSus)`
`279`		`- }`
`280`	`276`	`}`
`281`	`277`	`}`