Skip to content

Commit 220d1fb

Browse files
committed
remove tests relying on unauthorized access to Blinkist Premium
1 parent 2ef44f2 commit 220d1fb

File tree

4 files changed

+18
-19
lines changed

4 files changed

+18
-19
lines changed

.github/workflows/test.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,10 @@ jobs:
5858
- name: Test `--freedaily`
5959
run: |
6060
python main.py --freedaily /home/runner/Musik/Blinkist/
61-
# NOTE: The following should require a paid plan, but doesn't. Let's see for how much longer it works.
62-
- name: Test `--book-slug`
63-
run: |
64-
python main.py --book-slug get-smart-en /home/runner/Musik/Blinkist/
61+
# NOTE: The following requires Blinkist Premium.
62+
# - name: Test `--book-slug`
63+
# run: |
64+
# python main.py --book-slug get-smart-en /home/runner/Musik/Blinkist/
6565
- name: Check the directory contents
6666
run: |
6767
ls -hl /home/runner/Musik/Blinkist/*

tests/test_blinkist.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ def test_get_free_daily():
1212
def test_get_latest_books():
1313
books = blinkist.get_latest_books()
1414
assert len(books) > 0
15-
assert len(books) <= 8 # NOTE: We use <= becauase search_books filters out non-book results.
15+
assert len(books) <= 8 # NOTE: We use <= because search_books filters out non-book results.
1616
assert books[0].title
1717

1818

1919
def test_get_trending_books():
2020
books = blinkist.get_trending_books()
2121
assert len(books) > 0
22-
assert len(books) <= 8 # NOTE: We use <= becauase search_books filters out non-book results.
22+
assert len(books) <= 8 # NOTE: We use <= because search_books filters out non-book results.
2323
assert books[0].title
2424

2525

@@ -38,7 +38,7 @@ def test_default(self):
3838

3939
def test_limit(self):
4040
books = blinkist.search_books("smart", limit=5)
41-
assert len(books) <= 5 # NOTE: We use <= becauase search_books filters out non-book results.
41+
assert len(books) <= 5 # NOTE: We use <= because search_books filters out non-book results.
4242

4343
def test_languages(self):
4444
books = blinkist.search_books("smart", limit=10)

tests/test_book.py

+7-11
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,13 @@
1-
from blinkist.book import Book
2-
from blinkist.chapter import Chapter
3-
4-
# def test___init__():
5-
6-
# def test___repr__():
1+
import pytest
72

8-
# def test___hash__():
9-
10-
# def test___eq__():
3+
from blinkist import blinkist
4+
from blinkist.chapter import Chapter
115

12-
book = Book.from_slug('get-smart-en')
6+
# book = Book.from_slug('get-smart-en')
7+
book = blinkist.get_free_daily('en')
138

149

10+
@pytest.mark.skip(reason="Requires Blinkist Premium.")
1511
def test_from_slug():
1612
# ↓ book-specific
1713
assert book.title == "Get Smart!"
@@ -28,7 +24,7 @@ def test_chapters():
2824
assert all(chapter.data['text'] for chapter in book.chapters)
2925

3026
# ↓ book-specific
31-
assert len(book.chapters) == 1+9+1
27+
# assert len(book.chapters) == 1+9+1
3228

3329

3430
def test_download_cover(tmp_path):

tests/test_chapter.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,15 @@
11
import pytest
22

3+
from blinkist import blinkist
34
from blinkist.book import Book
45
from blinkist.chapter import Chapter
56

6-
book = Book.from_slug('get-smart-en')
7+
# book = Book.from_slug('get-smart-en')
8+
book = blinkist.get_free_daily('en')
79
chapter = book.chapters[0]
810

911

12+
@pytest.mark.skip(reason="Requires Blinkist Premium.")
1013
def test_from_id():
1114
chapter = Chapter.from_id(book, '58da6e44232de90004a6e66d')
1215
assert chapter.data['text']

0 commit comments

Comments
 (0)