Skip to content

Commit 189e9fe

Browse files
committed
Refactor: Removed unnecessary optional calls in recently used definitions.
1 parent 69a4c56 commit 189e9fe

6 files changed

Lines changed: 10 additions & 8 deletions

File tree

gnome-extensions/extension/features/RecentlyUsed/definitions/recentlyUsedDefinitionClipboardHistory.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ function createRecentlyUsedDefinitionClipboardHistoryInstance() {
8686
*/
8787
definition.getItems = ({ extension }) => {
8888
const clipboardManager = extension?._clipboardManager;
89-
return clipboardManager?.getHistoryItems?.() || [];
89+
return clipboardManager ? clipboardManager.getHistoryItems() : [];
9090
};
9191

9292
/**
@@ -103,7 +103,8 @@ function createRecentlyUsedDefinitionClipboardHistoryInstance() {
103103
}
104104

105105
const extension = runtimeContext?.extension;
106-
const historyIds = new Set((extension?._clipboardManager?.getHistoryItems?.() || []).map((item) => item?.id));
106+
const clipboardManager = extension?._clipboardManager;
107+
const historyIds = new Set((clipboardManager ? clipboardManager.getHistoryItems() : []).map((item) => item?.id));
107108
const providerItems = await searchViaProvider(ClipboardProvider.SEARCH_PROVIDER_ID, {
108109
query,
109110
context: { extension },

gnome-extensions/extension/features/RecentlyUsed/definitions/recentlyUsedDefinitionClipboardPinned.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ function createRecentlyUsedDefinitionClipboardPinnedInstance() {
9696
*/
9797
definition.getItems = ({ extension }) => {
9898
const clipboardManager = extension?._clipboardManager;
99-
return clipboardManager?.getPinnedItems?.() || [];
99+
return clipboardManager ? clipboardManager.getPinnedItems() : [];
100100
};
101101

102102
/**
@@ -113,7 +113,8 @@ function createRecentlyUsedDefinitionClipboardPinnedInstance() {
113113
}
114114

115115
const extension = runtimeContext?.extension;
116-
const pinnedIds = new Set((extension?._clipboardManager?.getPinnedItems?.() || []).map((item) => item?.id));
116+
const clipboardManager = extension?._clipboardManager;
117+
const pinnedIds = new Set((clipboardManager ? clipboardManager.getPinnedItems() : []).map((item) => item?.id));
117118
const providerItems = await searchViaProvider(ClipboardProvider.SEARCH_PROVIDER_ID, {
118119
query,
119120
context: { extension },

gnome-extensions/extension/features/RecentlyUsed/definitions/recentlyUsedDefinitionEmoji.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ function createRecentlyUsedDefinitionEmojiInstance() {
9494
* @returns {Array<object>} Emoji items.
9595
*/
9696
definition.getItems = () => {
97-
return recentManager?.getRecents?.() || [];
97+
return recentManager ? recentManager.getRecents() : [];
9898
};
9999

100100
/**

gnome-extensions/extension/features/RecentlyUsed/definitions/recentlyUsedDefinitionGif.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ function createRecentlyUsedDefinitionGifInstance() {
115115
* @returns {Array<object>} GIF items.
116116
*/
117117
definition.getItems = () => {
118-
return recentManager?.getRecents?.() || [];
118+
return recentManager ? recentManager.getRecents() : [];
119119
};
120120

121121
/**

gnome-extensions/extension/features/RecentlyUsed/definitions/recentlyUsedDefinitionKaomoji.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ function createRecentlyUsedDefinitionKaomojiInstance() {
100100
* @returns {Array<object>} Kaomoji items.
101101
*/
102102
definition.getItems = () => {
103-
return recentManager?.getRecents?.() || [];
103+
return recentManager ? recentManager.getRecents() : [];
104104
};
105105

106106
/**

gnome-extensions/extension/features/RecentlyUsed/definitions/recentlyUsedDefinitionSymbols.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ function createRecentlyUsedDefinitionSymbolsInstance() {
9494
* @returns {Array<object>} Symbol items.
9595
*/
9696
definition.getItems = () => {
97-
return recentManager?.getRecents?.() || [];
97+
return recentManager ? recentManager.getRecents() : [];
9898
};
9999

100100
/**

0 commit comments

Comments
 (0)