Fix: Remove unnecessary isCallable helper usage.

Author: NiffirgkcaJ

gnome-extensions/extension/features/RecentlyUsed/registry/recentlyUsedRuntimeService.js

@@ -1,4 +1,3 @@
-import { isCallable } from '../../../shared/utilities/utilityFunction.js';
 import { Logger } from '../../../shared/utilities/utilityLogger.js';
 
 import { ensureRecentlyUsedSectionDefinition } from './recentlyUsedSectionDefinition.js';
@@ -40,7 +39,7 @@ export class RecentlyUsedRuntimeService {
     constructor({ extension, settings, onRender }) {
         this._extension = extension;
         this._settings = settings;
-        this._onRender = isCallable(onRender) ? onRender : null;
+        this._onRender = onRender || null;
         this._started = false;
         this._orderedSections = [];
         this._sectionsById = new Map();
@@ -119,10 +118,6 @@ export class RecentlyUsedRuntimeService {
             return null;
         }
 
-        if (!isCallable(sectionDefinition.createInstance)) {
-            return sectionDefinition;
-        }
-
         try {
             const instance = sectionDefinition.createInstance();
             if (!instance || typeof instance !== 'object') {
@@ -404,7 +399,7 @@ export class RecentlyUsedRuntimeService {
      */
     _resolveSectionBrowseTitle(sectionConfig) {
         const browseTitleResolver = sectionConfig?.titlePolicy?.browseTitle;
-        if (isCallable(browseTitleResolver)) {
+        if (browseTitleResolver) {
             return browseTitleResolver();
         }
 
@@ -421,7 +416,7 @@ export class RecentlyUsedRuntimeService {
      */
     _resolveSectionSearchTitle(sectionConfig, fallbackTitle) {
         const searchTitleResolver = sectionConfig?.titlePolicy?.searchTitle;
-        if (isCallable(searchTitleResolver)) {
+        if (searchTitleResolver) {
             return searchTitleResolver();
         }
 

gnome-extensions/extension/features/RecentlyUsed/registry/recentlyUsedSearchStateManager.js

@@ -1,5 +1,3 @@
-import { isCallable } from '../../../shared/utilities/utilityFunction.js';
-
 import { matchesRecentlyUsedSearch } from '../utilities/recentlyUsedSearch.js';
 import { RecentlyUsedSearchTuning } from '../constants/recentlyUsedSearchConstants.js';
 
@@ -16,7 +14,7 @@ export class RecentlyUsedSearchStateManager {
      * @param {Function|null} options.onRender Callback to request re-render.
      */
     constructor({ onRender = null } = {}) {
-        this._onRender = isCallable(onRender) ? onRender : null;
+        this._onRender = onRender || null;
         this._searchRequestSeq = 0;
         this._sectionSearchState = new Map();
     }

gnome-extensions/extension/features/RecentlyUsed/registry/recentlyUsedSignalManager.js

@@ -1,4 +1,3 @@
-import { isCallable } from '../../../shared/utilities/utilityFunction.js';
 import { Logger } from '../../../shared/utilities/utilityLogger.js';
 
 import { RecentlyUsedPolicySettingKeys } from '../constants/recentlyUsedPolicyConstants.js';
@@ -19,10 +18,10 @@ export class RecentlyUsedSignalManager {
      * @param {Function|null} options.onRender Callback to request re-render.
      */
     constructor({ getOrderedSections, extension, settings, onRender }) {
-        this._getOrderedSections = isCallable(getOrderedSections) ? getOrderedSections : () => [];
+        this._getOrderedSections = getOrderedSections || (() => []);
         this._extension = extension;
         this._settings = settings;
-        this._onRender = isCallable(onRender) ? onRender : null;
+        this._onRender = onRender || null;
         this._signalIds = [];
     }
 
@@ -41,7 +40,7 @@ export class RecentlyUsedSignalManager {
         const id = descriptor?.id;
         const contextSuffix = context ? ` (${context})` : '';
 
-        if (!obj || !isCallable(obj.disconnect)) {
+        if (!obj?.disconnect) {
             if (warn) {
                 Logger.warn(`Ignoring invalid Recently Used signal descriptor${contextSuffix}: missing disconnect-capable object.`);
             }
@@ -98,7 +97,7 @@ export class RecentlyUsedSignalManager {
             });
         }
 
-        if (this._settings && isCallable(this._settings.connect)) {
+        if (this._settings?.connect) {
             RecentlyUsedPolicySettingKeys.forEach((settingKey) => {
                 try {
                     const signalId = this._settings.connect(`changed::${settingKey}`, () => {
@@ -142,7 +141,7 @@ export class RecentlyUsedSignalManager {
             const { obj, id } = normalized;
 
             try {
-                if (isCallable(obj.signal_handler_is_connected) && !obj.signal_handler_is_connected(id)) {
+                if (obj.signal_handler_is_connected && !obj.signal_handler_is_connected(id)) {
                     return;
                 }
                 obj.disconnect(id);

gnome-extensions/extension/shared/services/serviceSearchHub.js

@@ -1,5 +1,3 @@
-import { isCallable } from '../utilities/utilityFunction.js';
-
 const SEARCH_HANDOFF_TTL_MS = 10000;
 
 let _providersById = null;
@@ -154,7 +152,7 @@ function resolveProvider(providerId) {
  * @returns {Function} Unsubscribe function.
  */
 export function subscribeSearchHub(listener) {
-    if (!isCallable(listener)) {
+    if (!listener) {
         return () => {};
     }
 
@@ -187,9 +185,9 @@ export function registerSearchProvider(provider) {
     getProvidersById().set(providerId, {
         id: providerId,
         targetTabs,
-        search: isCallable(provider?.search) ? provider.search : null,
-        applyToTab: isCallable(provider?.applyToTab) ? provider.applyToTab : null,
-        clearOnTab: isCallable(provider?.clearOnTab) ? provider.clearOnTab : null,
+        search: provider?.search || null,
+        applyToTab: provider?.applyToTab || null,
+        clearOnTab: provider?.clearOnTab || null,
     });
 
     targetTabs.forEach((tabName) => {
@@ -245,7 +243,7 @@ export async function searchViaProvider(providerId, { query, context } = {}) {
     const provider = resolveProvider(providerId);
     const normalizedQuery = normalizeQuery(query);
 
-    if (!provider || !isCallable(provider.search) || !normalizedQuery) {
+    if (!provider?.search || !normalizedQuery) {
         return [];
     }
 
@@ -321,7 +319,7 @@ export async function applySearchHandoffToTab({ targetTab, tabActor } = {}) {
     }
 
     let applied = false;
-    if (provider && isCallable(provider.applyToTab)) {
+    if (provider?.applyToTab) {
         try {
             applied = Boolean(
                 await provider.applyToTab({
@@ -335,7 +333,7 @@ export async function applySearchHandoffToTab({ targetTab, tabActor } = {}) {
         }
     }
 
-    if (!applied && tabActor && isCallable(tabActor.applyExternalSearch)) {
+    if (!applied && tabActor?.applyExternalSearch) {
         try {
             applied = Boolean(await tabActor.applyExternalSearch(handoff.query, handoff));
         } catch {
@@ -363,7 +361,7 @@ export async function clearSearchOnTab({ targetTab, tabActor } = {}) {
     const resolvedProviderId = resolveProviderIdByTab(targetTab);
     const provider = resolveProvider(resolvedProviderId);
 
-    if (provider && isCallable(provider.clearOnTab)) {
+    if (provider?.clearOnTab) {
         try {
             return Boolean(
                 await provider.clearOnTab({
@@ -376,7 +374,7 @@ export async function clearSearchOnTab({ targetTab, tabActor } = {}) {
         }
     }
 
-    if (tabActor && isCallable(tabActor.clearExternalSearch)) {
+    if (tabActor?.clearExternalSearch) {
         try {
             return Boolean(await tabActor.clearExternalSearch());
         } catch {