Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Commit 91591b8

Browse files
authored
Merge branch 'master' into dep/dependency_upgrade_staging
2 parents 798210d + 1a4a39b commit 91591b8

5 files changed

Lines changed: 1 addition & 393 deletions

File tree

cerberus-web/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ dependencies {
5555
implementation "io.spinnaker.kork:kork-secrets:${versions.kork}"
5656

5757
// Misc
58-
implementation "com.netflix.hystrix:hystrix-core:1.5.18" // TODO remove hystrix and use resilience4j
5958
implementation "com.google.guava:guava:${versions.guava}" // todo, pretty sure with Java 11, we can get ride of this, we mostly use this for the collection builders.
6059
implementation 'com.google.code.gson:gson:2.9.1' // todo delete, should use jackson. see cipher text utils
6160

cerberus-web/src/main/java/com/nike/cerberus/jobs/HystrixMetricsProcessingJob.java

Lines changed: 0 additions & 157 deletions
This file was deleted.

cerberus-web/src/main/java/com/nike/cerberus/jobs/OrphanedKmsKeyCleanUpJob.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
import java.util.*;
2626
import java.util.stream.Collectors;
2727
import lombok.extern.slf4j.Slf4j;
28-
import org.apache.commons.lang.StringUtils;
28+
import org.apache.commons.lang3.StringUtils;
2929
import org.springframework.beans.factory.annotation.Autowired;
3030
import org.springframework.beans.factory.annotation.Value;
3131
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;

cerberus-web/src/main/resources/cerberus.yaml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -233,11 +233,6 @@ cerberus:
233233
# Every ten minutes
234234
cronExpression: "0 */10 * ? * *"
235235

236-
# Generates drop wizard metrics on the status of Hystrix for monitoring and alerting
237-
hystrixMetricsProcessingJob:
238-
enabled: true
239-
# Every ten seconds
240-
cronExpression: "0/10 * * ? * *"
241236

242237
# This job will generate Key Performance Indicator Metrics (KPIs) for the Cerberus environment and use Drop Wizard to report these Metrics
243238
# By default unless you provide your own reporter impl, these metrics are just logged via an SLF4j Logger.

0 commit comments

Comments
 (0)