Skip to content

Usability: with_axes() would be better as two methods: with_left_axis(), with_right_axis() #100

Description

@tlisonbee

Axis configuration on charts currently models the SignalFx REST API but it would be more developer friendly if it was changed.

Current API is a with_axes() method that takes an array with 1 or 2 AxisOptions, there is also a with_axis_precision() method that could move:

AxisOption(min=None, max=None, label='', high_watermark=None, low_watermark=None)

.with_axes([AxisOption(label="Count", min=0), AxisOption(label="Latency", min=0)])

.with_axis_precision(num)

Suggested API on charts:

.with_left_axis(label="", min=None, max=None, low_watermark=None, high_watermark=None, axis_precision=None)
.with_right_axis(label="", min=None, max=None, low_watermark=None, high_watermark=None, axis_precision=None)

(also, I think axis_precision is only currently supported for the left axis, above is suggested for both)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions