Skip to content

Disabling a Detector appears to have changed.  #103

Description

@greatestusername

Issue:
Disabling a detector no longer works.

Suspected Cause:
API change on SFX side. We used to pass in disabled:disabled as an option for a detector to disable it.
https://github.com/Nike-Inc/signal_analog/blob/master/signal_analog/detectors.py#L270-L280

Now it appears disabling a detector is with a PUT to /detector/{id}/disable
https://developers.signalfx.com/detectors_reference.html#tag/Disable-Single-Detector

We will need to refactor to grab the id for the matching detector to be disabled and hit that endpoint.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions