Merge pull request #59 from NillionNetwork/fix/decimal-parsing

fix: parse token price correctly

Author: mfontanini

Cargo.lock

@@ -18,7 +18,7 @@ metrics = "0.24"
 nilauth-client = { git = "https://github.com/NillionNetwork/nilauth-client-rs", rev = "ff2020b8b21b2719ece88d82b71a9fb84532170e" }
 nillion-nucs = { git = "https://github.com/NillionNetwork/nuc-rs", rev = "928bfb9bb1816396afbda33a6c5aa955a6b11641" }
 reqwest = { version = "0.12", default-features = false, features = ["rustls-tls"] }
-rust_decimal = "1.37"
+rust_decimal = { version = "1.39", features = ["serde-float", "serde-arbitrary-precision"] }
 serde = { version = "1.0", features = ["derive"] }
 serde_json = "1.0"
 serde_with = "3.14"

Cargo.toml

@@ -22,4 +22,4 @@ services:
     ports:
       - "30923:80"
     command: |
-      caddy respond --listen :80 --body '{"nillion":{"usd":1}}' --header "Content-Type: application/json" 
+      caddy respond --listen :80 --body '{"nillion":{"usd":1.0}}' --header "Content-Type: application/json" 

docker-compose.yml

@@ -159,7 +159,7 @@ pub struct PostgresConfig {
 }
 
 fn default_token_price_base_url() -> String {
-    "https://pro-api.coingecko.com/".into()
+    "https://pro-api.coingecko.com".into()
 }
 
 fn default_coin_id() -> String {

src/config.rs

@@ -55,7 +55,7 @@ impl TokenPriceService for CoinGeckoTokenPriceService {
         }
 
         let params = [("ids", self.coin_id.as_str()), ("vs_currencies", "usd")];
-        info!("Fetching token price from CoinGecko");
+        info!("Fetching token price from CoinGecko from URL {}, and params {params:?}", self.simple_price_url);
 
         let now = Instant::now();
         let response = self
@@ -64,7 +64,8 @@ impl TokenPriceService for CoinGeckoTokenPriceService {
             .query(&params)
             .header("X-CG-PRO-API-KEY", &self.api_key)
             .send()
-            .await;
+            .await
+            .and_then(|r| r.error_for_status());
         let elapsed = now.elapsed();
         histogram!("nil_token_price_fetch_seconds",).record(elapsed.as_millis() as f64 / 1000.0);
 
@@ -108,3 +109,14 @@ struct CachedPrice {
 struct TokenPrice {
     usd: Decimal,
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn token_price_parsing() {
+        let input = "0.249524";
+        serde_json::from_str::<Decimal>(input).expect("parse failed");
+    }
+}