Merge pull request #25 from NitorCreations/fixes

Decrease polling interval, fix race condition

Author: Jalle19

README.md

@@ -29,6 +29,11 @@ Not every single feature can be controlled, only the basics:
 
 The communication is done using Python's `asyncio` and requires no external libraries.
 
+## Caveats
+
+* SSP 200 surround sound processors seem to stop responding properly (both to commands and to physical interactions 
+  like button presses) after some time, requiring a reboot 
+
 ## Development
 
 Developing the integration and testing it locally in Home Assistant are two separate tasks.

custom_components/extron/__init__.py

@@ -11,7 +11,7 @@
 from homeassistant.helpers.device_registry import DeviceInfo, format_mac
 from pyextron import AuthenticationError, ExtronDevice
 
-from custom_components.extron.const import OPTION_INPUT_NAMES
+from custom_components.extron.const import EXTRON_DEVICE_TIMEOUT_SECONDS, OPTION_INPUT_NAMES
 
 PLATFORMS: list[Platform] = [Platform.MEDIA_PLAYER, Platform.SENSOR, Platform.BUTTON]
 _LOGGER = logging.getLogger(__name__)
@@ -56,7 +56,9 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
     """Set up Extron from a config entry."""
     # Verify we can connect to the device
     try:
-        device = ExtronDevice(entry.data["host"], entry.data["port"], entry.data["password"])
+        device = ExtronDevice(
+            entry.data["host"], entry.data["port"], entry.data["password"], timeout=EXTRON_DEVICE_TIMEOUT_SECONDS
+        )
         await device.connect()
         await device.disconnect()
     except AuthenticationError as e:

custom_components/extron/config_flow.py

@@ -11,7 +11,15 @@
 from homeassistant.helpers.selector import selector
 from pyextron import AuthenticationError, DeviceType, ExtronDevice
 
-from .const import CONF_DEVICE_TYPE, CONF_HOST, CONF_PASSWORD, CONF_PORT, DOMAIN, OPTION_INPUT_NAMES
+from .const import (
+    CONF_DEVICE_TYPE,
+    CONF_HOST,
+    CONF_PASSWORD,
+    CONF_PORT,
+    DOMAIN,
+    EXTRON_DEVICE_TIMEOUT_SECONDS,
+    OPTION_INPUT_NAMES,
+)
 
 _LOGGER = logging.getLogger(__name__)
 
@@ -45,7 +53,12 @@ async def async_step_user(self, user_input: dict[str, Any] | None = None):
         if user_input is not None:
             try:
                 # Try to connect to the device
-                extron_device = ExtronDevice(user_input["host"], user_input["port"], user_input["password"])
+                extron_device = ExtronDevice(
+                    user_input["host"],
+                    user_input["port"],
+                    user_input["password"],
+                    timeout=EXTRON_DEVICE_TIMEOUT_SECONDS,
+                )
                 await extron_device.connect()
 
                 # Make a title for the entry

custom_components/extron/const.py

@@ -1,5 +1,7 @@
 """Constants for the Extron integration."""
 
+from datetime import timedelta
+
 DOMAIN = "extron"
 
 CONF_HOST = "host"
@@ -8,3 +10,8 @@
 CONF_DEVICE_TYPE = "device_type"
 
 OPTION_INPUT_NAMES = "input_names"
+
+EXTRON_DEVICE_TIMEOUT_SECONDS = 10
+
+# Poll entities every 30 seconds
+SCAN_INTERVAL = timedelta(minutes=30)

custom_components/extron/media_player.py

@@ -203,4 +203,5 @@ def create_source_bidict(self) -> bidict:
         return make_source_bidict(num_sources, self._input_names)
 
     async def async_select_source(self, source: str):
-        await self._hdmi_switcher.select_input(self._source_bidict.inverse.get(source))
+        async with self._hdmi_switcher._device.connection():
+            await self._hdmi_switcher.select_input(self._source_bidict.inverse.get(source))