More double descent fixes and lint fixes

Author: CubesterYT

src/compiler/irgen.js

@@ -683,22 +683,22 @@ class ScriptTreeGenerator {
         case 'comments_reporter':
             return new IntermediateInput(InputOpcode.COMMENTS_REPORTER, InputType.ANY, {
                 value: this.descendInputOfBlock(block, 'VALUE'),
-                comment: this.descendInputOfBlock(block, 'COMMENT').toType(InputType.STRING),
+                comment: this.descendInputOfBlock(block, 'COMMENT').toType(InputType.STRING)
             });
         case 'comments_boolean':
             return new IntermediateInput(InputOpcode.COMMENTS_BOOLEAN, InputType.BOOLEAN, {
                 value: this.descendInputOfBlock(block, 'VALUE').toType(InputType.BOOLEAN),
-                comment: this.descendInputOfBlock(block, 'COMMENT').toType(InputType.STRING),
+                comment: this.descendInputOfBlock(block, 'COMMENT').toType(InputType.STRING)
             });
         case 'comments_object':
             return new IntermediateInput(InputOpcode.COMMENTS_OBJECT, InputType.OBJECT, {
                 value: this.descendInputOfBlock(block, 'VALUE').toType(InputType.OBJECT),
-                comment: this.descendInputOfBlock(block, 'COMMENT').toType(InputType.STRING),
+                comment: this.descendInputOfBlock(block, 'COMMENT').toType(InputType.STRING)
             });
         case 'comments_array':
             return new IntermediateInput(InputOpcode.COMMENTS_ARRAY, InputType.ARRAY, {
                 value: this.descendInputOfBlock(block, 'VALUE').toType(InputType.ARRAY),
-                comment: this.descendInputOfBlock(block, 'COMMENT').toType(InputType.STRING),
+                comment: this.descendInputOfBlock(block, 'COMMENT').toType(InputType.STRING)
             });
 
         case 'tw_getLastKeyPressed':

src/compiler/jsexecute.js

@@ -52,6 +52,37 @@ runtimeFunctions.arrayIndexOf = `const arrayIndexOf = (array, item) => {
     return index;
 }`;
 
+/**
+ * Replaces an item at the defined index in an array
+ * @param {Array<*>} array The array
+ * @param {number} index The index of the item to replace
+ * @param {*} item The replacement item
+ * @returns {Array<*>} Updated array with the replaced item
+ */
+runtimeFunctions.arrayReplaceAtIndex = `const arrayReplaceAtIndex = (array, index, item) => {
+    if (index >= 0 && index < array.length) {
+        const newArray = [...array];
+        newArray[index] = item;
+        return newArray;
+    }
+    return new Array();
+}`;
+
+/**
+ * Deletes an item at the defined index in an array
+ * @param {Array<*>} array The array
+ * @param {number} index The index of the item to delete
+ * @returns {Array<*>} Updated array after deleting the item
+ */
+runtimeFunctions.arrayDeleteAtIndex = `const arrayDeleteAtIndex = (array, index) => {
+    if (index >= 0 && index < array.length) {
+        const newArray = [...array];
+        newArray.splice(index, 1);
+        return newArray;
+    }
+    return new Array();
+}`;
+
 /**
  * Determine whether the current tick is likely stuck.
  * This implements similar functionality to the warp timer found in Scratch.

src/compiler/jsgen.js

@@ -18,7 +18,7 @@ const {
     IntermediateScript,
     IntermediateRepresentation
 } = require('./intermediate');
-const { Stack } = require('immutable');
+const {Stack} = require('immutable');
 /* eslint-enable no-unused-vars */
 
 /**
@@ -291,9 +291,9 @@ class JSGenerator {
         case InputOpcode.JSON_ADD_ITEM:
             return `(array = ${this.descendInput(node.array)}.slice(0), array.push(${this.descendInput(node.item)}), array)`;
         case InputOpcode.JSON_REPLACE_INDEX:
-            return `(${this.descendInput(node.index)} >= 0 && ${this.descendInput(node.index)} < ${this.descendInput(node.array)}.length ? (array = [...${this.descendInput(node.array)}], array[${this.descendInput(node.index)}] = ${this.descendInput(node.item)}, array) : new Array())`;
+            return `arrayReplaceAtIndex(${this.descendInput(node.array)}, ${this.descendInput(node.index)}, ${this.descendInput(node.item)})`;
         case InputOpcode.JSON_DELETE_INDEX:
-            return `(${this.descendInput(node.index)} >= 0 && ${this.descendInput(node.index)} < ${this.descendInput(node.array)}.length ? (array = [...${this.descendInput(node.array)}], array.splice(${this.descendInput(node.index)}, 1), array) : new Array())`;
+            return `arrayDeleteAtIndex(${this.descendInput(node.array)}, ${this.descendInput(node.index)})`;
         case InputOpcode.JSON_DELETE_ALL_OCCURRENCES:
             return `${this.descendInput(node.array)}.filter((item) => item !== ${this.descendInput(node.item)})`;
         case InputOpcode.JSON_MERGE_ARRAY: