Skip to content

Commit 4570d8f

Browse files
nk3.updates: Remove reboot during update
In v0.3.0, we added a reboot during the update to ensure that the device status is up to date. This was by mistake – we decided to skip this change for better compatibility with QubesOS. The current implementation was broken anyway as the device handle used for the reboot to bootloader was invalidated by the first reboot.
1 parent ec4cfd0 commit 4570d8f

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## Unreleased
44

5-
-
5+
- `nitropy.nk3.updates`: Remove reboot during update.
66

77
[All Changes](https://github.com/Nitrokey/nitrokey-sdk-py/compare/v0.3.0...HEAD)
88

src/nitrokey/nk3/updates.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -274,13 +274,8 @@ def update(
274274
update_from_bootloader = True
275275
self._trigger_warning(Warning.UPDATE_FROM_BOOTLOADER)
276276
elif isinstance(device, NK3):
277-
# We reboot here so that the status is always up to date
278-
device.reboot()
279-
time.sleep(1)
280-
281-
with self.await_device(3, None) as device:
282-
current_version = device.admin.version()
283-
status = device.admin.status()
277+
current_version = device.admin.version()
278+
status = device.admin.status()
284279
else:
285280
raise self.ui.error(f"Unexpected Trussed device: {device}")
286281

0 commit comments

Comments
 (0)