feat: don't match test derivations

Author: fricklerhandwerk

src/shared/listeners/automatic_linkage.py

@@ -91,10 +91,17 @@ def produce_linkage_candidates(
     # TODO: record what is used to expand the candidate list.
     candidates: dict[NixDerivation, ProvenanceFlags] = {}
     # TODO: improve accuracy by using bigrams similarity with a `| Q(...)` query.
-    matches = NixDerivation.objects.filter(
-        package_q | product_q,
-        parent_evaluation__in=list(latest_complete_channels),
-    ).annotate(**annotations)
+    matches = (
+        NixDerivation.objects.exclude(
+            # Test derivations are a Nixpkgs implementation detail and never represent software to be distributed.
+            attribute__startswith="tests.",
+        )
+        .filter(
+            package_q | product_q,
+            parent_evaluation__in=list(latest_complete_channels),
+        )
+        .annotate(**annotations)
+    )
     for drv in matches.iterator():
         flags = getattr(drv, "package_match", 0) | getattr(drv, "product_match", 0)
         candidates[drv] = ProvenanceFlags(flags)

src/shared/tests/test_linkage.py

@@ -229,3 +229,17 @@ def test_mixed_cpe_parts_skips_hardware_only_affected_products(
     suggestion = CVEDerivationClusterProposal.objects.get(cve=app_container.cve)
     assert suggestion.derivations.filter(name__startswith="myapp").exists()
     assert not suggestion.derivations.filter(name__startswith="some_router").exists()
+
+
+def test_ignore_tests(
+    cve: Container,
+    make_drv: Callable[..., NixDerivation],
+) -> None:
+    drv1 = make_drv(attribute="foo")
+    drv2 = make_drv(attribute="tests.foo")
+
+    assert build_new_links(cve)
+
+    suggestion = CVEDerivationClusterProposal.objects.get(cve=cve.cve)
+    assert suggestion.derivations.filter(attribute=drv1.attribute).exists()
+    assert not suggestion.derivations.filter(attribute=drv2.attribute).exists()