From d6139a339b98c3a5675757d6df52c79124d953b6 Mon Sep 17 00:00:00 2001
From: Robert Hensing <robert@roberthensing.nl>
Date: Thu, 27 Feb 2025 17:48:28 +0100
Subject: [PATCH] packaging: Make hydraJobs.build.* complete

---
 packaging/hydra.nix | 102 +++++++++++++++++++++++++++++++++-----------
 1 file changed, 78 insertions(+), 24 deletions(-)

diff --git a/packaging/hydra.nix b/packaging/hydra.nix
index 44cbd753c9b..74e245f26c5 100644
--- a/packaging/hydra.nix
+++ b/packaging/hydra.nix
@@ -29,32 +29,86 @@ let
   # Technically we could just return `pkgs.nixComponents`, but for Hydra it's
   # convention to transpose it, and to transpose it efficiently, we need to
   # enumerate them manually, so that we don't evaluate unnecessary package sets.
-  forAllPackages = lib.genAttrs [
-    "nix-everything"
-    "nix-util"
-    "nix-util-c"
-    "nix-util-test-support"
-    "nix-util-tests"
-    "nix-store"
-    "nix-store-c"
-    "nix-store-test-support"
-    "nix-store-tests"
-    "nix-fetchers"
-    "nix-fetchers-tests"
-    "nix-expr"
-    "nix-expr-c"
-    "nix-expr-test-support"
-    "nix-expr-tests"
-    "nix-flake"
-    "nix-flake-tests"
-    "nix-main"
-    "nix-main-c"
-    "nix-cmd"
-    "nix-cli"
-    "nix-functional-tests"
-  ];
+  # See listingIsComplete below.
+  forAllPackages = forAllPackages' { };
+  forAllPackages' =
+    {
+      enableBindings ? false,
+      enableDocs ? false, # already have separate attrs for these
+    }:
+    lib.genAttrs (
+      [
+        "nix-everything"
+        "nix-util"
+        "nix-util-c"
+        "nix-util-test-support"
+        "nix-util-tests"
+        "nix-store"
+        "nix-store-c"
+        "nix-store-test-support"
+        "nix-store-tests"
+        "nix-fetchers"
+        "nix-fetchers-tests"
+        "nix-expr"
+        "nix-expr-c"
+        "nix-expr-test-support"
+        "nix-expr-tests"
+        "nix-flake"
+        "nix-flake-c"
+        "nix-flake-tests"
+        "nix-main"
+        "nix-main-c"
+        "nix-cmd"
+        "nix-cli"
+        "nix-functional-tests"
+      ]
+      ++ lib.optionals enableBindings [
+        "nix-perl-bindings"
+      ]
+      ++ lib.optionals enableDocs [
+        "nix-manual"
+        "nix-internal-api-docs"
+        "nix-external-api-docs"
+      ]
+    );
 in
 {
+  /**
+    An internal check to make sure our package listing is complete.
+  */
+  listingIsComplete =
+    let
+      arbitrarySystem = "x86_64-linux";
+      listedPkgs = forAllPackages' {
+        enableBindings = true;
+        enableDocs = true;
+      } (_: null);
+      actualPkgs = lib.concatMapAttrs (
+        k: v: if lib.strings.hasPrefix "nix-" k then { ${k} = null; } else { }
+      ) nixpkgsFor.${arbitrarySystem}.native.nixComponents;
+      diff = lib.concatStringsSep "\n" (
+        lib.concatLists (
+          lib.mapAttrsToList (
+            k: _:
+            if (listedPkgs ? ${k}) && !(actualPkgs ? ${k}) then
+              [ "- ${k}: redundant?" ]
+            else if !(listedPkgs ? ${k}) && (actualPkgs ? ${k}) then
+              [ "- ${k}: missing?" ]
+            else
+              [ ]
+          ) (listedPkgs // actualPkgs)
+        )
+      );
+    in
+    if listedPkgs == actualPkgs then
+      { }
+    else
+      throw ''
+        Please update the components list in hydra.nix (or fix this check)
+        Differences:
+        ${diff}
+      '';
+
   # Binary package for various platforms.
   build = forAllPackages (
     pkgName: forAllSystems (system: nixpkgsFor.${system}.native.nixComponents.${pkgName})