Skip to content

shell: pin a Nixpkgs that supports x86_64-darwin#545390

Merged
mdaniels5757 merged 1 commit into
NixOS:masterfrom
MattSturgeon:pin-26.05-darwin
Jul 25, 2026
Merged

shell: pin a Nixpkgs that supports x86_64-darwin#545390
mdaniels5757 merged 1 commit into
NixOS:masterfrom
MattSturgeon:pin-26.05-darwin

Conversation

@MattSturgeon

@MattSturgeon MattSturgeon commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

When instantiating a dev-shell for x86_64-darwin, we cannot use CI's pinned 26.11 revision. Instead, we must use a revision that still supports x86_64-darwin.

Print a warning when we need to use that revision, because it is likely there will be subtle formatting & linting differences vs CI.

Unblocks backporting #544224 and #545265.

Initially opened this PR against release-26.05 to see CI working. I've since rebased & re-targeted to master. Once merged we will backport as normal.

Things done

nixpkgs-commit-check[bot]

This comment was marked as outdated.

@nixpkgs-ci
nixpkgs-ci Bot requested review from a team and infinisil July 24, 2026 21:34
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: flakes The experimental Nix feature 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 4.workflow: backport This targets a stable branch labels Jul 24, 2026
@MattSturgeon

MattSturgeon commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Tested against 26.05, together with the recent ci/pinned bumps from master: https://github.com/NixOS/nixpkgs/actions/runs/30127775588/job/89595329084?pr=545390#step:5:70

(treefmt failure is expected, because I didn't cherry-pick the relevant zizmore fixes)

I'll rebase on master now:

When instantiating a dev-shell for x86_64-darwin, we cannot use 26.11's
pinned revision. Instead, we must use a revision that still supports
x86_64-darwin.

Print a warning when we need to use that revision, because it is likely
there will be subtle formatting & linting differences vs CI.
@MattSturgeon
MattSturgeon changed the base branch from release-26.05 to master July 24, 2026 21:38
@nixpkgs-ci nixpkgs-ci Bot closed this Jul 24, 2026
@nixpkgs-ci nixpkgs-ci Bot reopened this Jul 24, 2026
@nixpkgs-commit-check
nixpkgs-commit-check Bot dismissed their stale review July 24, 2026 21:39

Review dismissed automatically

@nixpkgs-ci nixpkgs-ci Bot added backport release-26.05 Backport PR automatically and removed 4.workflow: backport This targets a stable branch labels Jul 24, 2026
@mdaniels5757
mdaniels5757 added this pull request to the merge queue Jul 25, 2026
Merged via the queue into NixOS:master with commit 09d9cc7 Jul 25, 2026
137 of 177 checks passed
@nixpkgs-ci

nixpkgs-ci Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Backport failed for release-26.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-26.05
git worktree add -d .worktree/backport-545390-to-release-26.05 origin/release-26.05
cd .worktree/backport-545390-to-release-26.05
git switch --create backport-545390-to-release-26.05
git cherry-pick -x f86bce24974ec79a2d5e2c3668bde6475baf36cd

@mdaniels5757 mdaniels5757 added 8.has: port to stable This PR already has a backport to the stable release. and removed 8.has: failed backport backport release-26.05 Backport PR automatically labels Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: flakes The experimental Nix feature 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants