chore(CI): run tests on different distributions

Author: mayeut

.github/workflows/ci.yml

@@ -28,3 +28,91 @@ jobs:
         mkdir build && cd build
         ../configure --with-asan --with-ubsan
         make -j$(nproc) check
+
+  distro_matrix:
+    name: build distribution matrix
+    runs-on: ubuntu-latest
+    outputs:
+      matrix: ${{ steps.matrix.outputs.matrix }}
+    steps:
+      - id: matrix
+        name: build matrix
+        shell: python
+        run: |
+          import os
+          import json
+          runner = {
+              "x86_64": "ubuntu-24.04",
+              "i686": "ubuntu-24.04",
+              "aarch64": "ubuntu-24.04-arm",
+              "armv7l": "ubuntu-24.04-arm",
+              "ppc64le": "ubuntu-24.04",
+              "s390x": "ubuntu-24.04",
+              "riscv64": "ubuntu-24.04",
+          }
+          reduced = [
+              ("almalinux:8",  ("x86_64", "aarch64", "ppc64le", "s390x")),
+              ("almalinux:9",  ("x86_64", "aarch64", "ppc64le", "s390x")),
+              ("centos:7",     ("x86_64", "i686", "aarch64", "ppc64le", "s390x")),
+              ("debian:10",    ("x86_64", "i686", "aarch64", "armv7l")),
+              ("debian:11",    ("x86_64", "i686", "aarch64", "armv7l")),
+              ("debian:12",    ("x86_64", "i686", "aarch64", "armv7l", "ppc64le", "s390x")),
+              ("ubuntu:18.04", ("x86_64", "i686", "aarch64", "armv7l", "ppc64le", "s390x")),
+              ("ubuntu:20.04", ("x86_64", "aarch64", "armv7l", "ppc64le", "s390x", "riscv64")),
+              ("ubuntu:22.04", ("x86_64", "aarch64", "armv7l", "ppc64le", "s390x", "riscv64")),
+              ("ubuntu:24.04", ("x86_64", "aarch64", "armv7l", "ppc64le", "s390x", "riscv64")),
+          ]
+          expanded = [{"distro": distro, "platform": platform, "runner": runner[platform]} for distro, platforms in reduced for platform in platforms]
+          print(json.dumps(expanded, indent=2))
+          with open(os.environ["GITHUB_OUTPUT"], "at") as f:
+              f.write(f"matrix={json.dumps(expanded)}")
+
+  distro_check:
+    needs: distro_matrix
+    name: ${{ matrix.distro }} ${{ matrix.platform }}
+    runs-on: ${{ matrix.runner }}
+    timeout-minutes: 10
+    strategy:
+      fail-fast: false
+      matrix:
+        include: ${{ fromJson(needs.distro_matrix.outputs.matrix) }}
+    steps:
+    - uses: actions/checkout@v4
+    - name: Set up QEMU
+      if: runner.arch == 'X64' && matrix.platform != 'x86_64'
+      uses: docker/setup-qemu-action@v3
+    - run: |
+        # ${{ matrix.distro }} ${{ matrix.platform }} tests
+        cat <<EOF > build.sh
+        set -e
+        set -x
+
+        case "${{ matrix.distro }}" in
+            ubuntu*|debian*) apt-get update && apt-get -y install automake g++ make;;
+        esac
+
+        c++ --version
+        ld --version
+        autoconf --version
+        ./bootstrap.sh
+        mkdir build && cd build
+        ../configure
+        make -j$(nproc) check || (cat tests/test-suite.log; exit 1)
+        EOF
+
+        case "${{ matrix.platform }}" in
+            x86_64) DOCKER_PLATFORM=amd64;;
+            i686) DOCKER_PLATFORM=386;;
+            aarch64) DOCKER_PLATFORM=arm64/v8;;
+            armv7l) DOCKER_PLATFORM=arm/v7;;
+            *) DOCKER_PLATFORM=${{ matrix.platform }};;
+        esac
+
+        case "${{ matrix.distro }}" in
+            centos:7) IMAGE=quay.io/pypa/manylinux2014_${{ matrix.platform }}:latest;;
+            almalinux:8) IMAGE=quay.io/pypa/manylinux_2_28_${{ matrix.platform }}:latest;;
+            almalinux:9) IMAGE=quay.io/pypa/manylinux_2_34_${{ matrix.platform }}:latest;;
+            *) IMAGE=${{ matrix.distro }}
+        esac
+
+        docker run --platform linux/${DOCKER_PLATFORM} -v $(pwd):/gha ${IMAGE} sh -ec "cd /gha && bash ./build.sh"

tests/replace-add-needed.sh

@@ -11,7 +11,17 @@ cp libbar.so "${SCRATCH}"/
 
 cd "${SCRATCH}"
 
-libcldd=$(ldd ./simple | awk '/ => / { print $3 }' | grep -E "(libc(-[0-9.]*)*.so|ld-musl)")
+# QEMU & ldd are not playing well together in certain cases
+CHECK_QEMU=0
+libcldd=$(ldd ./simple | awk '/ => / { print $3 }' | grep -E "(libc(-[0-9.]*)*.so|ld-musl)") || CHECK_QEMU=1
+if [ "${CHECK_QEMU}" -ne 0 ]; then
+    if [ -f /lib64/libc.so.6 ] && grep qemu /proc/1/cmdline >/dev/null 2>&1; then
+        libcldd=/lib64/libc.so.6
+    else
+        echo "ldd ./simple failed"
+        exit 1
+    fi
+fi
 
 # We have to set the soname on these libraries
 ${PATCHELF} --set-soname libbar.so ./libbar.so

tests/set-interpreter-long.sh

@@ -6,7 +6,12 @@ SCRATCH=scratch/$(basename "$0" .sh)
 oldInterpreter=$(../src/patchelf --print-interpreter ./simple)
 echo "current interpreter is $oldInterpreter"
 
-if test "$(uname)" = Linux; then
+RUN_EXPLICIT_INTERPRETER=0
+if [ "$(uname)" = Linux ] && ! grep qemu /proc/1/cmdline >/dev/null 2>&1; then  # QEMU & ldd/ld.so are not playing well together in certain cases
+    RUN_EXPLICIT_INTERPRETER=1
+fi
+
+if [ "${RUN_EXPLICIT_INTERPRETER}" -ne 0 ]; then
     echo "running with explicit interpreter..."
     "$oldInterpreter" ./simple
 fi
@@ -28,7 +33,7 @@ echo "running with new interpreter..."
 ln -s "$oldInterpreter" "$newInterpreter"
 "${SCRATCH}"/simple
 
-if test "$(uname)" = Linux; then
+if [ "${RUN_EXPLICIT_INTERPRETER}" -ne 0 ]; then
     echo "running with explicit interpreter..."
     "$oldInterpreter" "${SCRATCH}/simple"
 fi