Skip to content

Commit 4265b08

Browse files
remove non-argument about encouraging a principled approach
the convention indeed does not encourage discipline, as @andir points out[1], and at the worst would encourage haphazard changes because it makes them appear harmless, as @tazjin adds [2]. [1]: https://github.com/NixOS/rfcs/pull/137/files#r1050542977 [2]: https://github.com/NixOS/rfcs/pull/137/files#r1050580213
1 parent c6d692c commit 4265b08

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

rfcs/0137-nix-language-version.md

+6-2
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,15 @@ where `<version>` is a released version of Nix the given file is intended to wor
3939
# Arguments
4040
[advantages]: #advantages
4141

42-
* (+) Encourages developing Nix to deal with changes to the Nix language in a principled manner.
42+
* (+) Makes explicit what can be expected to work.
43+
* (+) Enables communicating language changes systematically.
4344
* (+) Backwards-compatible
4445
* (+) Allows for gradual adoption: opt-in until semantics is implemented in Nix *and* the first backwards-incompatible change to the language is introduced.
4546
* (+) Visually unintrusive
4647
* (+) Self-describing and human-readable
4748
* (+) Follows a well-known convention of using [magic numbers in files](https://en.m.wikipedia.org/wiki/Magic_number_(programming)#In_files)
49+
* (-) May make the appearance that changing the language is harmless.
50+
* (+) The convention itself is harmless and independent of the development culture around the language.
4851
* (-) The syntax of the magic comment is arbitrary.
4952
* (-) There is a chance of abusing the magic comment for more metadata in the future. Let's avoid that.
5053
* (-) At least one form of comment is forever bound to begin with `#` to maintain compatibility.
@@ -91,4 +94,5 @@ where `<version>` is a released version of Nix the given file is intended to wor
9194
# Future work
9295
[future]: #future-work
9396

94-
Define semantics, that is, what exactly to do with the information given in the magic comment.
97+
- Define semantics, that is, what exactly to do with the information given in the magic comment.
98+
- Define rules deciding when a change to the language is appropriate to avoid proliferation and limit complexity of implementation.

0 commit comments

Comments
 (0)