misc: Fix typing for client timeout#621
Merged
jmoralez merged 2 commits intoNixtla:mainfrom Mar 26, 2025
adamantike:misc/fix-client-timeout-typing
Merged
misc: Fix typing for client timeout#621jmoralez merged 2 commits intoNixtla:mainfrom adamantike:misc/fix-client-timeout-typing
jmoralez merged 2 commits intoNixtla:mainfrom
adamantike:misc/fix-client-timeout-typing
Conversation
Member
|
@adamantike - Thanks for the PR. We use |
The `timeout` parameter in the `NixtlaClient` class can be set as `None` to disable the timeout, as explained in the docstring.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
Author
|
Thanks for the context! I should have checked out the contributing guidelines, but thought it was a one-line fix. PR updated! |
jmoralez
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
timeoutparameter in theNixtlaClientclass can be set asNoneto disable the timeout, as explained in the docstring.