Skip to content

misc: Fix typing for client timeout#621

Merged
jmoralez merged 2 commits intoNixtla:mainfrom
adamantike:misc/fix-client-timeout-typing
Mar 26, 2025
Merged

misc: Fix typing for client timeout#621
jmoralez merged 2 commits intoNixtla:mainfrom
adamantike:misc/fix-client-timeout-typing

Conversation

@adamantike
Copy link
Contributor

The timeout parameter in the NixtlaClient class can be set as None to disable the timeout, as explained in the docstring.

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2025

CLA assistant check
All committers have signed the CLA.

@ngupta23
Copy link
Member

@adamantike - Thanks for the PR. We use nbdev for developing this repo. You may need to update the notebook instead of the py file and then use nbdev_export to create the py files from it. Please see the instructions here. I hope this helps.

The `timeout` parameter in the `NixtlaClient` class can be set as `None`
to disable the timeout, as explained in the docstring.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@adamantike
Copy link
Contributor Author

Thanks for the context! I should have checked out the contributing guidelines, but thought it was a one-line fix. PR updated!

@jmoralez jmoralez merged commit 16d4610 into Nixtla:main Mar 26, 2025
5 of 20 checks passed
@jmoralez jmoralez added the fix label Mar 26, 2025
@adamantike adamantike deleted the misc/fix-client-timeout-typing branch March 26, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants