[Maintenance] Boost phpstan

Author: NoResponseMate

phpstan.neon.dist

@@ -3,18 +3,16 @@ includes:
     - vendor/phpstan/phpstan-webmozart-assert/extension.neon
 
 parameters:
-    level: 3
-
-    reportUnmatchedIgnoredErrors: false
+    level: 6
 
     paths:
-        - 'src/'
+        - src
 
     excludePaths:
         # Makes PHPStan crash
         - 'src/DependencyInjection/Configuration.php'
-        - 'src/DependencyInjection/SyliusPayPalExtension.php'
 
-        # Test dependencies
-        - 'tests/Application/app/**.php'
-        - 'tests/Application/src/**.php'
+    ignoreErrors:
+        - identifier: missingType.iterableValue
+
+        - '/Dead catch - Sylius\\PayPalPlugin\\Exception\\PayPalWebhookUrlNotValidException is never thrown in the try block\./' # architectural smell

src/Api/CacheAuthorizeClientApi.php

@@ -22,6 +22,7 @@
 
 final readonly class CacheAuthorizeClientApi implements CacheAuthorizeClientApiInterface
 {
+    /** @param ObjectRepository<PayPalCredentialsInterface> $payPalCredentialsRepository */
     public function __construct(
         private ObjectManager $payPalCredentialsManager,
         private ObjectRepository $payPalCredentialsRepository,
@@ -32,7 +33,6 @@ public function __construct(
 
     public function authorize(PaymentMethodInterface $paymentMethod): string
     {
-        /** @var PayPalCredentialsInterface|null $payPalCredentials */
         $payPalCredentials = $this->payPalCredentialsRepository->findOneBy(['paymentMethod' => $paymentMethod]);
         if ($payPalCredentials !== null && !$payPalCredentials->isExpired()) {
             return $payPalCredentials->accessToken();

src/Console/Command/CompletePaidPaymentsCommand.php

@@ -35,6 +35,7 @@
 )]
 final class CompletePaidPaymentsCommand extends Command
 {
+    /** @param PaymentRepositoryInterface<PaymentInterface> $paymentRepository */
     public function __construct(
         private readonly PaymentRepositoryInterface $paymentRepository,
         private readonly ObjectManager $paymentManager,

src/Controller/CancelLastPayPalPaymentAction.php

@@ -25,6 +25,7 @@
 
 final readonly class CancelLastPayPalPaymentAction
 {
+    /** @param OrderRepositoryInterface<OrderInterface> $orderRepository */
     public function __construct(
         private ObjectManager $objectManager,
         private StateMachineInterface $stateMachineFactory,

src/Controller/CancelPayPalOrderAction.php

@@ -13,6 +13,7 @@
 
 namespace Sylius\PayPalPlugin\Controller;
 
+use Sylius\Component\Core\Model\OrderInterface;
 use Sylius\Component\Core\Repository\OrderRepositoryInterface;
 use Sylius\PayPalPlugin\Provider\FlashBagProvider;
 use Sylius\PayPalPlugin\Provider\PaymentProviderInterface;
@@ -22,6 +23,7 @@
 
 final readonly class CancelPayPalOrderAction
 {
+    /** @param OrderRepositoryInterface<OrderInterface>|null $orderRepository */
     public function __construct(
         private ?PaymentProviderInterface $paymentProvider,
         private ?OrderRepositoryInterface $orderRepository,

src/Controller/DownloadPayoutsReportAction.php

@@ -22,6 +22,7 @@
 
 final readonly class DownloadPayoutsReportAction
 {
+    /** @param PaymentMethodRepositoryInterface<PaymentMethodInterface> $paymentMethodRepository */
     public function __construct(
         private PayoutsReportDownloaderInterface $payoutsReportDownloader,
         private PaymentMethodRepositoryInterface $paymentMethodRepository,
@@ -30,7 +31,6 @@ public function __construct(
 
     public function __invoke(Request $request): Response
     {
-        /** @var PaymentMethodInterface|null $paymentMethod */
         $paymentMethod = $this->paymentMethodRepository->find($request->attributes->getInt('id'));
         Assert::notNull($paymentMethod);
 

src/Controller/EnableSellerAction.php

@@ -25,6 +25,7 @@
 
 final readonly class EnableSellerAction
 {
+    /** @param PaymentMethodRepositoryInterface<PaymentMethodInterface> $paymentMethodRepository */
     public function __construct(
         private PaymentMethodRepositoryInterface $paymentMethodRepository,
         private PaymentMethodEnablerInterface $paymentMethodEnabler,
@@ -33,7 +34,6 @@ public function __construct(
 
     public function __invoke(Request $request): Response
     {
-        /** @var PaymentMethodInterface $paymentMethod */
         $paymentMethod = $this->paymentMethodRepository->find($request->attributes->getInt('id'));
         /** @var FlashBagInterface $flashBag */
         $flashBag = $request->getSession()->getBag('flashes');

src/Controller/PayPalButtonsController.php

@@ -28,6 +28,7 @@
 
 final readonly class PayPalButtonsController
 {
+    /** @param OrderRepositoryInterface<OrderInterface> $orderRepository */
     public function __construct(
         private Environment $twig,
         private UrlGeneratorInterface $router,

src/Controller/PayWithPayPalFormAction.php

@@ -28,6 +28,7 @@
 
 final readonly class PayWithPayPalFormAction
 {
+    /** @param PaymentRepositoryInterface<PaymentInterface> $paymentRepository */
     public function __construct(
         private Environment $twig,
         private PaymentRepositoryInterface $paymentRepository,

src/Controller/ProcessPayPalOrderAction.php

@@ -16,24 +16,30 @@
 use Doctrine\Persistence\ObjectManager;
 use Sylius\Abstraction\StateMachine\StateMachineInterface;
 use Sylius\Component\Core\Factory\AddressFactoryInterface;
+use Sylius\Component\Core\Model\AddressInterface;
 use Sylius\Component\Core\Model\CustomerInterface;
 use Sylius\Component\Core\Model\PaymentInterface;
 use Sylius\Component\Core\Model\PaymentMethodInterface;
 use Sylius\Component\Core\OrderCheckoutTransitions;
 use Sylius\Component\Core\Repository\CustomerRepositoryInterface;
-use Sylius\Component\Resource\Factory\FactoryInterface;
 use Sylius\PayPalPlugin\Api\CacheAuthorizeClientApiInterface;
 use Sylius\PayPalPlugin\Api\OrderDetailsApiInterface;
 use Sylius\PayPalPlugin\Exception\PaymentAmountMismatchException;
 use Sylius\PayPalPlugin\Manager\PaymentStateManagerInterface;
 use Sylius\PayPalPlugin\Provider\OrderProviderInterface;
 use Sylius\PayPalPlugin\Verifier\PaymentAmountVerifierInterface;
+use Sylius\Resource\Factory\FactoryInterface;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 
 final readonly class ProcessPayPalOrderAction
 {
+    /**
+     * @param CustomerRepositoryInterface<CustomerInterface> $customerRepository
+     * @param FactoryInterface<CustomerInterface> $customerFactory
+     * @param AddressFactoryInterface<AddressInterface> $addressFactory
+     */
     public function __construct(
         private CustomerRepositoryInterface $customerRepository,
         private FactoryInterface $customerFactory,
@@ -85,6 +91,7 @@ public function __invoke(Request $request): Response
 
         if ($order->isShippingRequired()) {
             $name = explode(' ', $purchaseUnit['shipping']['name']['full_name']);
+            /** @phpstan-ignore-next-line false positive */
             $address->setLastName(array_pop($name) ?? '');
             $address->setFirstName(implode(' ', $name));
             $address->setStreet($purchaseUnit['shipping']['address']['address_line_1']);