Cancel payment only if it's possible

Author: LucaGallinari

src/Controller/CancelPayPalPaymentAction.php

@@ -59,22 +59,24 @@ public function __invoke(Request $request): Response
          * @var string $content
          */
         $content = $request->getContent();
-
         $content = (array) json_decode($content, true);
 
         $payment = $this->paymentProvider->getByPayPalOrderId((string) $content['payPalOrderId']);
 
         /** @var OrderInterface $order */
         $order = $payment->getOrder();
 
-        $this->getStateMachine()->apply($payment, PaymentTransitions::GRAPH, PaymentTransitions::TRANSITION_CANCEL);
+        $paymentStateMachine = $this->getStateMachine();
+        if ($paymentStateMachine->can($payment, PaymentTransitions::GRAPH, PaymentTransitions::TRANSITION_CANCEL)) {
+            $paymentStateMachine->apply($payment, PaymentTransitions::GRAPH, PaymentTransitions::TRANSITION_CANCEL);
 
-        $this->orderPaymentProcessor->process($order);
-        $this->objectManager->flush();
+            $this->orderPaymentProcessor->process($order);
+            $this->objectManager->flush();
 
-        FlashBagProvider::getFlashBag($this->flashBagOrRequestStack)
-            ->add('success', 'sylius.pay_pal.payment_cancelled')
-        ;
+            FlashBagProvider::getFlashBag($this->flashBagOrRequestStack)
+                ->add('success', 'sylius.pay_pal.payment_cancelled')
+            ;
+        }
 
         return new Response('', Response::HTTP_NO_CONTENT);
     }