Fixes for lint/misplaced-type-hint and naming/record-name

Author: NoahTheDuke

CHANGELOG.md

@@ -23,11 +23,13 @@ This changelog is loose. Versions are not semantic, they are incremental. Splint
 
 - Disable `lint/thread-macro-one-arg` by default. It harms readability in a lot of cases and has limited usefulness.
 - `:import` parsing now includes both the base class name as well as the fully qualified class name in the returned map, which improves all interop scenarios.
+- Include the misplaced type hint in the `Form` output of `lint/misplaced-type-hint`.
 
 ### Fixed
 
 - Correctly resolve auto-resolving keywords in the current namespace: `(ns foo) ::bar` will be parsed as `:foo/bar` instead of `:splint-auto-current/bar`.
 - `naming/lisp-case` now only looks at symbols.
+- `naming/record-name` doesn't crash when analyzing `` `(defrecord ~@body)``.
 
 ## 1.20.0 - 2025-03-28
 

src/noahtheduke/splint/rules/lint/misplaced_type_hint.clj

@@ -41,8 +41,11 @@
      (when-let [defn-form (:splint/defn-form (meta form))]
        (when-let [tag (:tag defn-form)]
          (let [arities (:arities defn-form)
+               tag (symbol (str "^" tag))
                arities (if (= 1 (count (:arities defn-form)))
-                         (cons (symbol (str "^" tag)) (first arities))
-                         (map #(cons (symbol (str "^" tag)) %) arities))
-               replace-form (->list (list* ?defn (:splint/name defn-form) arities))]
-           (->diagnostic ctx rule form {:replace-form replace-form})))))})
+                         (cons tag (first arities))
+                         (map #(cons tag %) arities))
+               replace-form (->list (list* ?defn (:splint/name defn-form) arities))
+               original-form (with-meta (->list (list* ?defn tag (next form)))
+                               (meta form))]
+           (->diagnostic ctx rule original-form {:replace-form replace-form})))))})

src/noahtheduke/splint/rules/naming/record_name.clj

@@ -11,8 +11,9 @@
 (set! *warn-on-reflection* true)
 
 (defn bad-name? [sexp]
-  (let [record-name (str sexp)]
-    (not= record-name (csk/->PascalCase record-name))))
+  (when (symbol? sexp)
+    (let [record-name (str sexp)]
+      (not= record-name (csk/->PascalCase record-name)))))
 
 (defrule naming/record-name
   "Records should use PascalCase. (Replacement is generated with [camel-snake-kebab](https://github.com/clj-commons/camel-snake-kebab).)

test/noahtheduke/splint/rules/lint/misplaced_type_hint_test.clj

@@ -19,14 +19,14 @@
   (it "handles single arities"
     (expect-match
     [{:rule-name rule-name
-      :form '(defn make-str [] "abc")
+      :form (list 'defn (symbol "^String") 'make-str [] "abc")
       :alt (list 'defn 'make-str (symbol "^String") [] "abc")}]
     "(defn ^String make-str [] \"abc\")"
     (config)))
   (it "handles multi-arities"
     (expect-match
       [{:rule-name rule-name
-        :form '(defn make-str ([] "abc") ([a] (str a "abc")))
+        :form (list 'defn (symbol "^String") 'make-str '([] "abc") '([a] (str a "abc")))
         :alt (list 'defn 'make-str (list (symbol "^String") [] "abc")
                    (list (symbol "^String") '[a] '(str a "abc")))}]
       "(defn ^String make-str ([] \"abc\") ([a] (str a \"abc\")))"

test/noahtheduke/splint/rules/naming/record_name_test.clj

@@ -36,4 +36,10 @@
         :form '(defrecord Foo-bar [a b c])
         :alt '(defrecord FooBar [a b c])}]
       "(defrecord Foo-bar [a b c])"
+      (single-rule-config rule-name)))
+  (it "doesn't crash in a macro"
+    {:focus true}
+    (expect-match
+      nil
+      "`(defrecord ~@body)"
       (single-rule-config rule-name))))