🚨 feat(middleware-test-runner): require --spec parameter, validate input, and update help/README.

Author: Biont

machines/middleware-test-runner/README.md

@@ -14,35 +14,32 @@ A state machine-based test runner for executing acceptance criteria tests define
 
 ### Basic Usage
 ```bash
-# Run all tests in the default spec file
-ddev exec machines/middleware-test-runner/run.sh
+# Run tests (--spec parameter is required)
+ddev exec machines/middleware-test-runner/run.sh --spec=specs/core/region.yaml
 
 # Or directly via PHP
-ddev exec php machines/middleware-test-runner/machine.php
+ddev exec php machines/middleware-test-runner/machine.php --spec=specs/core/region.yaml
 ```
 
 ### Command Line Options
 
 ```bash
 # Show only errors (quiet mode)
-ddev exec machines/middleware-test-runner/run.sh --quiet
-ddev exec machines/middleware-test-runner/run.sh -q
+ddev exec machines/middleware-test-runner/run.sh --spec=specs/chain/middleware.yaml --quiet
+ddev exec machines/middleware-test-runner/run.sh --spec=specs/chain/middleware.yaml -q
 
 # Show detailed output including test outputs (verbose mode)
-ddev exec machines/middleware-test-runner/run.sh --verbose
-ddev exec machines/middleware-test-runner/run.sh -v
+ddev exec machines/middleware-test-runner/run.sh --spec=specs/core/region.yaml --verbose
+ddev exec machines/middleware-test-runner/run.sh --spec=specs/core/region.yaml -v
 
 # Stop on first failure
-ddev exec machines/middleware-test-runner/run.sh --stop-on-failure
-
-# Run tests from a specific spec file
-ddev exec machines/middleware-test-runner/run.sh --spec=specs/myspec.yaml
+ddev exec machines/middleware-test-runner/run.sh --spec=specs/core/region.yaml --stop-on-failure
 
 # Run only a specific feature group
-ddev exec machines/middleware-test-runner/run.sh --group=chain
+ddev exec machines/middleware-test-runner/run.sh --spec=specs/chain/middleware.yaml --group=chain
 
 # Combine options
-ddev exec machines/middleware-test-runner/run.sh --quiet --stop-on-failure
+ddev exec machines/middleware-test-runner/run.sh --spec=specs/core/region.yaml --quiet --stop-on-failure
 ```
 
 ### Help

machines/middleware-test-runner/machine.php

@@ -18,7 +18,7 @@
 function parseArguments(array $argv): array
 {
     $options = [
-        'specPath' => __DIR__ . '/../../specs/chain/middleware.yaml',
+        'specPath' => null,
         'stopOnFailure' => false,
         'group' => null,
         'quiet' => false,
@@ -43,6 +43,20 @@ function parseArguments(array $argv): array
         }
     }
 
+    // Validate required parameters
+    if ($options['specPath'] === null) {
+        echo "❌ ERROR: --spec parameter is required\n";
+        echo "\n";
+        echo "Usage: machines/middleware-test-runner/run.sh --spec=<path> [options]\n";
+        echo "\n";
+        echo "Examples:\n";
+        echo "  machines/middleware-test-runner/run.sh --spec=specs/core/region.yaml\n";
+        echo "  machines/middleware-test-runner/run.sh --spec=specs/chain/middleware.yaml --quiet\n";
+        echo "\n";
+        echo "Run with --help for more options.\n";
+        exit(1);
+    }
+    
     return $options;
 }
 

machines/middleware-test-runner/run.sh

@@ -1,7 +1,7 @@
 #!/bin/bash
 
 # Unified Test Runner Script
-# Usage: ./run.sh [options]
+# Usage: ./run.sh --spec=<path> [options]
 
 set -e
 
@@ -12,23 +12,24 @@ for arg in "$@"; do
         --help)
             echo "Unified Test Runner"
             echo ""
-            echo "Usage: ./run.sh [options]"
+            echo "Usage: ./run.sh --spec=<path> [options]"
+            echo ""
+            echo "Required:"
+            echo "  --spec=<path>         Path to spec YAML file (required)"
             echo ""
             echo "Options:"
-            echo "  --spec=<path>         Path to spec YAML file (default: specs/chain/middleware.yaml)"
-            echo "  --group=<n>           Run only specific feature group"
+            echo "  --group=<name>        Run only specific feature group"
             echo "  --stop-on-failure     Stop execution on first failure"
             echo "  --quiet, -q           Suppress output except for errors (quiet mode)"
             echo "  --verbose, -v         Show detailed output including test outputs"
             echo "  --help                Show this help message"
             echo ""
             echo "Examples:"
-            echo "  ./run.sh                                    # Run all tests"
-            echo "  ./run.sh --group=chain                      # Run only chain tests"
-            echo "  ./run.sh --stop-on-failure                  # Stop on first failure"
-            echo "  ./run.sh --quiet                            # Show only errors"
-            echo "  ./run.sh --verbose                          # Show detailed output"
-            echo "  ./run.sh --spec=specs/myspec.yaml           # Use custom spec file"
+            echo "  ./run.sh --spec=specs/core/region.yaml"
+            echo "  ./run.sh --spec=specs/chain/middleware.yaml --quiet"
+            echo "  ./run.sh --spec=specs/core/region.yaml --group=state-management"
+            echo "  ./run.sh --spec=specs/core/region.yaml --stop-on-failure"
+            echo "  ./run.sh --spec=specs/core/region.yaml --verbose"
             exit 0
             ;;
         *)