Skip to content

refactor: move provider to background thread#1486

Draft
Wodann wants to merge 2 commits into
mainfrom
refactor/provider-on-background-thread
Draft

refactor: move provider to background thread#1486
Wodann wants to merge 2 commits into
mainfrom
refactor/provider-on-background-thread

Conversation

@Wodann

@Wodann Wodann commented Jun 18, 2026

Copy link
Copy Markdown
Member

Replaces the synchronisation mechanism of the JSON-RPC provider from mutexes and tokio blocking threads to channels and a dedicated OS thread.

@Wodann Wodann added the no changeset needed This PR doesn't require a changeset label Jun 18, 2026
@Wodann Wodann temporarily deployed to github-action-benchmark June 18, 2026 03:28 — with GitHub Actions Inactive
@changeset-bot

changeset-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 30ee8a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Wodann Wodann had a problem deploying to github-action-benchmark June 18, 2026 03:30 — with GitHub Actions Failure
@Wodann Wodann temporarily deployed to github-action-benchmark June 18, 2026 03:30 — with GitHub Actions Inactive
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.75581% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.40%. Comparing base (f41d964) to head (30ee8a5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/edr_provider/src/backend.rs 85.23% 42 Missing and 2 partials ⚠️
crates/edr_provider/src/provider.rs 85.71% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1486      +/-   ##
==========================================
- Coverage   79.40%   79.40%   -0.01%     
==========================================
  Files         446      446              
  Lines       76607    76655      +48     
  Branches    76607    76655      +48     
==========================================
+ Hits        60832    60868      +36     
- Misses      13654    13666      +12     
  Partials     2121     2121              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from refactor/cancellable-thread to main June 18, 2026 15:04
@Wodann Wodann force-pushed the refactor/provider-on-background-thread branch from 65b08b7 to 3f812fe Compare June 18, 2026 18:56
@Wodann Wodann had a problem deploying to github-action-benchmark June 18, 2026 18:56 — with GitHub Actions Error
@Wodann Wodann force-pushed the refactor/provider-on-background-thread branch from 3f812fe to c689632 Compare June 18, 2026 18:57
@Wodann Wodann temporarily deployed to github-action-benchmark June 18, 2026 18:57 — with GitHub Actions Inactive
@Wodann

Wodann commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

/bench

@Wodann Wodann had a problem deploying to github-action-benchmark June 18, 2026 19:00 — with GitHub Actions Failure
@Wodann Wodann temporarily deployed to github-action-benchmark June 18, 2026 19:00 — with GitHub Actions Inactive
@Wodann Wodann temporarily deployed to github-action-benchmark June 19, 2026 14:02 — with GitHub Actions Inactive
@Wodann Wodann temporarily deployed to github-action-benchmark June 19, 2026 14:04 — with GitHub Actions Inactive
@Wodann Wodann temporarily deployed to github-action-benchmark June 19, 2026 14:04 — with GitHub Actions Inactive
@Wodann

Wodann commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

/bench

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Starting regression benchmark for 30ee8a5c9bcf against Hardhat main.

@Wodann

Wodann commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

/bench

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Starting regression benchmark for 30ee8a5c9bcf against Hardhat main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changeset needed This PR doesn't require a changeset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant