[v2] refactor language analysis into separate passes (#1457)

This PR splits the language v2 definition analysis into independent
passes, rather than the monolith that existed in v1.
It also fixes a bug in the v2 test runner, where it was picking up the
v1 old tests, rather than running its own.

> NOTE: this is a set of PRs to add the lexer v2, to make reviewing
smaller chunks easier:
>
> 1. #1457
> 2. #1458
> 3. #1459
> 4. #1460
> 5. #1461
> 6. #1462

Author: OmarTawfik

Cargo.lock

@@ -1,17 +1,15 @@
-mod definitions;
-mod reachability;
-mod references;
-mod utils;
+mod p1_definitions;
+mod p2_version_specifiers;
+mod p3_references;
+mod p4_unreachabe_items;
+mod p5_unused_versions;
 
 use std::rc::Rc;
 
 use indexmap::IndexMap;
 use proc_macro2::Span;
 
-use crate::compiler::analysis::definitions::analyze_definitions;
-use crate::compiler::analysis::reachability::analyze_reachability;
-use crate::compiler::analysis::references::analyze_references;
-use crate::compiler::version_set::VersionSet;
+use crate::compiler::utils::version_set::VersionSet;
 use crate::internals::{ErrorsCollection, ParseOutput, Spanned};
 use crate::model::{Identifier, SpannedItem, SpannedLanguage};
 
@@ -42,27 +40,21 @@ impl Analysis {
             metadata: IndexMap::new(),
         };
 
-        // Early return if there are already errors, to prevent producing noise from later analysis:
-        if analysis.errors.has_errors() {
-            return analysis;
+        for pass in &[
+            p1_definitions::run,
+            p2_version_specifiers::run,
+            p3_references::run,
+            p4_unreachabe_items::run,
+            p5_unused_versions::run,
+        ] {
+            // Early return if there are already errors, to prevent producing noise from later analysis:
+            if analysis.errors.has_errors() {
+                return analysis;
+            }
+
+            pass(&mut analysis);
         }
 
-        analyze_definitions(&mut analysis);
-
-        // Early return if there are already errors, to prevent producing noise from later analysis:
-        if analysis.errors.has_errors() {
-            return analysis;
-        }
-
-        analyze_references(&mut analysis);
-
-        // Early return if there are already errors, to prevent producing noise from later analysis:
-        if analysis.errors.has_errors() {
-            return analysis;
-        }
-
-        analyze_reachability(&mut analysis);
-
         analysis
     }
 }

crates/language-v2/definition/src/compiler/analysis/mod.rs

@@ -2,14 +2,14 @@ use std::collections::HashSet;
 use std::rc::Rc;
 
 use crate::compiler::analysis::{Analysis, ItemMetadata};
-use crate::compiler::version_set::VersionSet;
+use crate::compiler::utils::version_set::VersionSet;
 use crate::internals::Spanned;
 use crate::model::{
     Identifier, SpannedField, SpannedItem, SpannedOperatorModel, SpannedPrecedenceOperator,
     SpannedVersionSpecifier,
 };
 
-pub(crate) fn analyze_definitions(analysis: &mut Analysis) {
+pub(crate) fn run(analysis: &mut Analysis) {
     collect_top_level_items(analysis);
 
     check_enum_items(analysis);
@@ -198,9 +198,9 @@ fn calculate_defined_in(analysis: &mut Analysis, item: &SpannedItem) -> VersionS
 
     let mut try_add_specifier = |specifier: &Option<Spanned<SpannedVersionSpecifier>>| {
         if let Some(specifier) = specifier {
-            analysis.add_specifier(&mut defined_in, specifier);
+            defined_in.add_specifier(specifier, &analysis.language);
         } else {
-            analysis.add_all_versions(&mut defined_in);
+            defined_in.add_all_versions(&analysis.language);
         }
     };