Added built-in breaking versions to language breaking versions (#1480)

We now consider built-in changes as language breaking changes.

Author: teofr

crates/codegen/generator/src/lib.rs

@@ -68,7 +68,7 @@ impl RuntimeModel {
             slang_version: CargoWorkspace::local_version()?,
             language_name: language.name.to_string(),
             all_language_versions: language.versions.iter().cloned().collect(),
-            breaking_language_versions: language.collect_breaking_versions(),
+            breaking_language_versions: language.collect_grammar_breaking_versions(),
 
             ast: AstModel::from_language(language),
             bindings: BindingsModel::from_language(language)?,

crates/codegen/spec/src/generators/supported_versions.rs

@@ -27,7 +27,7 @@ pub fn generate_supported_versions(model: &SpecModel) -> Result<String> {
 
     let breaking_versions = model
         .language
-        .collect_breaking_versions()
+        .collect_all_breaking_versions()
         .iter()
         .map(|version| format!("`{version}`"))
         .collect_vec();

crates/codegen/testing/src/common.rs

@@ -101,7 +101,7 @@ pub(crate) fn generate_unit_test_file(
 pub(crate) fn generate_version_breaks(language: &Language, output_dir: &Path) -> Result<()> {
     let mut fs = CodegenFileSystem::default();
 
-    let versions = language.collect_breaking_versions();
+    let versions = language.collect_all_breaking_versions();
     let versions_len = versions.len();
 
     let mut contents = String::new();

crates/language-v2/definition/src/model/manifest.rs

@@ -38,10 +38,20 @@ impl Language {
         self.topics().flat_map(|topic| &topic.items)
     }
 
-    /// Collects all versions that change the language grammar in a breaking way.
+    /// Collects all versions that change the language in a breaking way.
     ///
     /// Includes the first supported version.
-    pub fn collect_breaking_versions(&self) -> BTreeSet<Version> {
+    pub fn collect_all_breaking_versions(&self) -> BTreeSet<Version> {
+        let mut ans = self.collect_grammar_breaking_versions();
+        ans.append(&mut self.collect_built_ins_versions());
+
+        ans
+    }
+
+    /// Collects all versions that change the language grammar in a breaking way.
+    ///
+    /// Note: this does not include built-ins related breaks, consider using `collect_all_breaking_versions` instead.
+    pub fn collect_grammar_breaking_versions(&self) -> BTreeSet<Version> {
         let first = self.versions.first().unwrap().clone();
         let mut res = BTreeSet::from_iter([first]);
 
@@ -108,6 +118,8 @@ impl Language {
     ///
     /// Includes the first supported version. Returns an empty set if there are
     /// no built-ins defined.
+    ///
+    /// Note: this does not include grammar related breaks, consider using `collect_all_breaking_versions` instead.
     pub fn collect_built_ins_versions(&self) -> BTreeSet<Version> {
         if self.built_ins.is_empty() {
             return BTreeSet::new();

crates/language/definition/src/model/manifest.rs

@@ -38,10 +38,20 @@ impl Language {
         self.topics().flat_map(|topic| &topic.items)
     }
 
-    /// Collects all versions that change the language grammar in a breaking way.
+    /// Collects all versions that change the language in a breaking way.
     ///
     /// Includes the first supported version.
-    pub fn collect_breaking_versions(&self) -> BTreeSet<Version> {
+    pub fn collect_all_breaking_versions(&self) -> BTreeSet<Version> {
+        let mut ans = self.collect_grammar_breaking_versions();
+        ans.append(&mut self.collect_built_ins_versions());
+
+        ans
+    }
+
+    /// Collects all versions that change the language grammar in a breaking way.
+    ///
+    /// Note: this does not include built-ins related breaks, consider using `collect_all_breaking_versions` instead.
+    pub fn collect_grammar_breaking_versions(&self) -> BTreeSet<Version> {
         let first = self.versions.first().unwrap().clone();
         let mut res = BTreeSet::from_iter([first]);
 
@@ -110,6 +120,8 @@ impl Language {
     ///
     /// Includes the first supported version. Returns an empty set if there are
     /// no built-ins defined.
+    ///
+    /// Note: this does not include grammar related breaks, consider using `collect_all_breaking_versions` instead.
     pub fn collect_built_ins_versions(&self) -> BTreeSet<Version> {
         if self.built_ins.is_empty() {
             return BTreeSet::new();