Resolve identifiers in assembly blocks to locally imported symbols (#1424)

Fix #1421 

Even if the imported symbol cannot be resolved, the identifier should
still resolve to the local definition in the import statement, so that
code in assembly blocks is consistent with normal Solidity code.

---------

Co-authored-by: Beta Ziliani <beta.ziliani@gmail.com>

Author: ggiraldez

.changeset/eleven-parents-look.md

@@ -0,0 +1,5 @@
+---
+"@nomicfoundation/slang": patch
+---
+
+Resolve identifiers in assembly blocks to locally imported symbols

crates/solidity/inputs/language/bindings/rules.msgb

@@ -260,21 +260,15 @@ inherit .star_extension
   node @symbol.import
   edge @symbol.import -> @path.import
 
-  node @symbol.yul_def
-  edge @import.yul_defs -> @symbol.yul_def
-  node @symbol.yul_import
-  edge @symbol.yul_import -> @import.yul_path
+  edge @import.yul_defs -> @symbol.def
+  edge @symbol.import -> @import.yul_path
 }
 
 @symbol [ImportDeconstructionSymbol @name name: [Identifier] .] {
   attr (@symbol.def) node_definition = @name
   attr (@symbol.def) definiens_node = @symbol
   attr (@symbol.import) node_reference = @name
   edge @symbol.def -> @symbol.import
-
-  attr (@symbol.yul_def) pop_symbol = (source-text @name)
-  attr (@symbol.yul_import) push_symbol = (source-text @name)
-  edge @symbol.yul_def -> @symbol.yul_import
 }
 
 @symbol [ImportDeconstructionSymbol
@@ -285,10 +279,6 @@ inherit .star_extension
   attr (@symbol.def) definiens_node = @symbol
   attr (@symbol.import) node_reference = @name
   edge @symbol.def -> @symbol.import
-
-  attr (@symbol.yul_def) pop_symbol = (source-text @alias)
-  attr (@symbol.yul_import) push_symbol = (source-text @name)
-  edge @symbol.yul_def -> @symbol.yul_import
 }
 
 

crates/solidity/outputs/cargo/crate/src/generated/bindings/generated/binding_rules.rs

@@ -0,0 +1,5 @@
+# This file is generated automatically by infrastructure scripts. Please don't edit by hand.
+
+reference `FOO` at main.sol:6:26 failed to resolve in new binder
+
+Definitions and/or references from binding graph and new binder DIFFER

crates/solidity/outputs/cargo/tests/src/binder/generated/yul.rs

@@ -0,0 +1,5 @@
+# This file is generated automatically by infrastructure scripts. Please don't edit by hand.
+
+Ref: ["FOO" @ main.sol:6:26] -> #1 resolved uniquely but resolved ambiguously in stack graph output
+
+Definitions and/or references from binding graph and new binder DIFFER

crates/solidity/outputs/cargo/tests/src/bindings/bindings_output/generated/yul.rs

@@ -22,7 +22,7 @@ References and definitions:
    │                       │   │   
    │                       ╰─────── ref: built-in
    │                           │   
-   │                           ╰─── unresolved
+   │                           ╰─── ref: 1
 ───╯
 Definiens: 
    ╭─[main.sol:1:1]

crates/solidity/testing/snapshots/bindings_output/yul/imported_deconstructed_constants/diff/generated/0.4.11-failure-diff.txt

@@ -22,7 +22,7 @@ References and definitions:
    │                       │   │   
    │                       ╰─────── ref: built-in
    │                           │   
-   │                           ╰─── unresolved
+   │                           ╰─── ref: 1
 ───╯
 Definiens: 
    ╭─[main.sol:1:1]