more comms tests

Author: maxd-nordic

tests/test_comms.py

@@ -51,6 +51,7 @@
     select_jlink,
     select_device_by_serial,
     select_device,
+    Comms,
 )
 
 Port = namedtuple("Port", ["hwid", "device"])
@@ -236,6 +237,11 @@ def ports_linux_jlink_multi_com():
         m.comports.return_value = list_ports_linux_jlink_multi_com
         yield m
 
+@pytest.fixture
+def mock_serial():
+    """Mock the serial.Serial class."""
+    with patch("nrfcredstore.comms.serial.Serial", autospec=True) as mock_serial:
+        yield mock_serial
 
 # Tests for get_connected_nordic_boards
 
@@ -441,3 +447,44 @@ def test_select_device_no_list_all_more_devices(
         )
     assert port.device == port_to_select.device
     assert serial_number == "THINGY91X_F39CC1B120C"
+
+# tests for expect_response
+
+def test_expect_response_ok(mock_serial):
+    with patch("nrfcredstore.comms.select_device", return_value=(Mock(), "123456789")) as mock_select:
+        comms = Comms()
+        comms.read_line = Mock(return_value="OK")
+        result, output = comms.expect_response("OK", "ERROR")
+        mock_select.assert_called_once()
+        assert result is True
+        assert output == ''
+
+def test_expect_response_error(mock_serial):
+    with patch("nrfcredstore.comms.select_device", return_value=(Mock(), "123456789")) as mock_select:
+        comms = Comms()
+        comms.read_line = Mock(return_value="ERROR")
+        result, output = comms.expect_response("OK", "ERROR")
+        mock_select.assert_called_once()
+        assert result is False
+        assert output == ''
+
+def test_expect_response_error_not_allowed(mock_serial):
+    with patch("nrfcredstore.comms.select_device", return_value=(Mock(), "123456789")) as mock_select:
+        with patch("nrfcredstore.comms.logging.error") as mock_error:
+            comms = Comms()
+            comms.read_line = Mock(return_value="+CME ERROR: 514")
+            result, output = comms.expect_response("OK", "ERROR")
+            mock_select.assert_called_once()
+            assert result is False
+            assert output == ''
+            mock_error.assert_called_once_with("AT command error: Not allowed")
+
+def test_expect_response_timeout(mock_serial):
+    with patch("nrfcredstore.comms.select_device", return_value=(Mock(), "123456789")) as mock_select:
+        comms = Comms()
+        comms.read_line = Mock(return_value="")
+        result, output = comms.expect_response("OK", "ERROR", timeout=1)
+        mock_select.assert_called_once()
+        assert result is False
+        assert output == ''
+