wip

Author: maxd-nordic

src/nrfcredstore/at_client.py

@@ -21,7 +21,7 @@ def __init__(self, comms : Comms):
     def __at_command_ok(self, cmd):
         """Send AT command and return a bool whether the modem response was OK/ERROR."""
         try:
-            self.at_command(cmd)
+            return 'OK' in self.at_command(cmd)
         except ATCommandError as err:
             print(err)
             return False

tests/test_at_client.py

@@ -24,23 +24,23 @@ def at_client(self):
 
     @pytest.fixture
     def ok_resp(self, at_client):
-        self.comms.read_line.return_value = 'OK\r\n'
+        self.comms.read_line.return_value = 'OK'
 
     @pytest.fixture
     def not_at_client_resp(self, at_client):
         self.comms.read_line.side_effect = ['AT: command not found', '']
 
     @pytest.fixture
     def error_resp(self, at_client):
-        self.comms.read_line.return_value = 'ERROR\r\n'
+        self.comms.read_line.return_value = 'ERROR'
 
     @pytest.fixture
     def error_code_resp(self, at_client):
-        self.comms.read_line.return_value = '+CME ERROR: 514\r\n'
+        self.comms.read_line.return_value = '+CME ERROR: 514'
 
     @pytest.fixture
     def error_code_0_resp(self, at_client):
-        self.comms.read_line.return_value = '+CME ERROR: 0\r\n'
+        self.comms.read_line.return_value = '+CME ERROR: 0'
 
     @pytest.fixture
     def error_ok_resp(self, at_client):