Remove unnecesary validations (#20)

Error handling is managed in at_client.py so there is no need to
validate again errors in other parts of the code

Signed-off-by: Pascal Hernandez <[email protected]>

Author: pascal-nordic

src/nrfcredstore/cli.py

@@ -89,8 +89,6 @@ def exec_cmd(args, credstore):
         ct = CredType[args.type]
         if credstore.delete(args.tag, ct):
             print(f'{ct.name} in secure tag {args.tag} deleted')
-        else:
-            raise RuntimeError('delete failed')
     elif args.subcommand=='generate':
         credstore.keygen(args.tag, args.file, args.attributes)
         print(f'New private key generated in secure tag {args.tag}')

src/nrfcredstore/credstore.py

@@ -26,9 +26,6 @@ def __init__(self, tag: int, type: int, sha: str):
         self.type = CredType(type)
         self.sha = sha
 
-def is_ok(response_lines):
-    return not any("ERROR" in line for line in response_lines) 
-
 class CredStore:
     def __init__(self, at_client):
         self.at_client = at_client
@@ -80,7 +77,7 @@ def write(self, tag: int, type: CredType, file: io.TextIOBase):
         if type == CredType.ANY:
             raise ValueError
         cert = file.read().rstrip()
-        return is_ok(self.at_client.at_command(f'AT%CMNG=0,{tag},{type.value},"{cert}"'))
+        return self.at_client.at_command(f'AT%CMNG=0,{tag},{type.value},"{cert}"')
 
     def delete(self, tag: int, type: CredType):
         """Delete a credential from the modem
@@ -90,7 +87,7 @@ def delete(self, tag: int, type: CredType):
 
         if type == CredType.ANY:
             raise ValueError
-        return is_ok(self.at_client.at_command(f'AT%CMNG=3,{tag},{type.value}'))
+        return self.at_client.at_command(f'AT%CMNG=3,{tag},{type.value}')
 
     def keygen(self, tag: int, file: io.BufferedIOBase, attributes: str = ''):
         """Generate a new private key and return a certificate signing request in DER format"""

tests/test_credstore.py

@@ -107,7 +107,8 @@ def test_list_fail(self, cred_store, at_error):
             cred_store.list()
 
     def test_delete_success(self, cred_store, ok_resp):
-        assert cred_store.delete(567890, CredType(1))
+        response = cred_store.delete(567890, CredType(1))
+        assert len(response) == 0
         self.at_client.at_command.assert_called_with('AT%CMNG=3,567890,1')
 
     def test_delete_fail(self, cred_store, at_error):
@@ -123,7 +124,8 @@ def test_write_success(self, cred_store, ok_resp):
 dGVzdA==
 -----END CERTIFICATE-----'''
         fake_file = io.StringIO(cert_text)
-        assert cred_store.write(567890, CredType.CLIENT_KEY, fake_file)
+        response = cred_store.write(567890, CredType.CLIENT_KEY, fake_file)
+        assert len(response) == 0
         self.at_client.at_command.assert_called_with(f'AT%CMNG=0,567890,2,"{cert_text}"')
 
     def test_write_fail(self, cred_store, at_error):