allow symlinked ports

Signed-off-by: Maximilian Deubel <[email protected]>

Author: maxd-nordic

src/nrfcredstore/comms.py

@@ -20,6 +20,7 @@
 import coloredlogs, logging
 import re
 import platform
+import os
 from typing import Tuple, List, Union, Optional
 
 logger = logging.getLogger(__name__)
@@ -210,8 +211,9 @@ def select_device(rtt : bool, serial_number : Optional[Union[str, int]], port :
         return (None, select_jlink(jlinks, list_all))
 
     if port:
+        real_path = os.path.realpath(port)
         # Serial ports are unique, so we just check if it exists and try to get a serial number
-        serial_devices = [x for x in get_comports_fixed_ordering() if x.device == port]
+        serial_devices = [x for x in get_comports_fixed_ordering() if x.device == real_path]
         if len(serial_devices) == 0:
             raise Exception(f"No device found with port {port}")
         extracted_serial_number = extract_serial_number_from_serial_device(

tests/test_comms.py

@@ -116,6 +116,11 @@
     ),
 ]
 
+@pytest.fixture
+def mock_os_realpath():
+    with patch("nrfcredstore.comms.os.path.realpath", autospec=True) as m:
+        m.side_effect = lambda x: x  # identity function
+        yield m
 
 @pytest.fixture
 def platform_darwin():
@@ -351,7 +356,7 @@ def test_select_device_rtt_true_serial_number_not_found(platform_linux, ports_li
             )
 
 # port given
-def test_select_device_port_given(platform_linux, ports_linux_multi):
+def test_select_device_port_given(platform_linux, ports_linux_multi, mock_os_realpath):
     port, serial_number = select_device(
         rtt=False, serial_number=None, port="/dev/ttyACM0", list_all=False
     )