Merge branch 'release/0.4.5'

Author: roszcz

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## [0.4.5] - 2025-09-18
+### Fixed
+- audio rendering
+
 ## [0.4.3] - 2025-04-20
 ### Changed
 - time_shift is no longer an inplace op

fortepyan/__init__.py

@@ -4,7 +4,7 @@
 from fortepyan.midi.structures import MidiFile, MidiPiece
 
 __all__ = ["view", "MidiFile", "MidiPiece"]
-__version__ = "0.4.4"
+__version__ = "0.4.5"
 
 # Pretty MIDI will throw an unwanted error for large files with high PPQ
 # This is a workaround

fortepyan/audio/render.py

@@ -35,14 +35,16 @@ def midi_to_wav(midi: Union[structures.MidiFile, structures.MidiPiece], wavpath:
     """
     if isinstance(midi, structures.MidiPiece):
         midi = midi.to_midi()
+
     # This will be deleted
     tmp_midi_path = tempfile.mkstemp(suffix=".mid")[1]
 
     # Add an silent event to make sure the final notes
     # have time to ring out
-    end_time = midi.get_end_time() + 0.2
+    end_time = midi.duration + 0.2
     pedal_off = pretty_midi.ControlChange(64, 0, end_time)
-    midi.instruments[0].control_changes.append(pedal_off)
+
+    midi._midi.instruments[0].control_changes.append(pedal_off)
 
     midi.write(tmp_midi_path)
 

fortepyan/midi/structures.py

@@ -113,6 +113,12 @@ def time_shift(self, shift_s: float) -> "MidiPiece":
         new_piece.df.end += shift_s
         return new_piece
 
+    @classmethod
+    def empty(cls) -> "MidiPiece":
+        df = pd.DataFrame(columns=["start", "duration", "velocity", "pitch"])
+        piece = cls(df=df)
+        return piece
+
     def trim(
         self,
         start: float,
@@ -122,7 +128,7 @@ def trim(
 
         idx = np.where(ids)[0]
         if len(idx) == 0:
-            raise IndexError("No notes found in the specified range.")
+            return MidiPiece.empty()
 
         start_idx = idx[0]
         finish_idx = idx[-1] + 1

pyproject.toml

@@ -6,7 +6,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "fortepyan"
-version = "0.4.4"
+version = "0.4.5"
 description = "Process MIDI piano with (almost) no pain"
 readme = "README.md"
 authors = [{ name = "Piano For AI", email = "roszcz+fortepyan@gmail.com" }]
@@ -59,7 +59,7 @@ packages = [
 ]
 
 [tool.bumpver]
-current_version = "0.4.4"
+current_version = "0.4.5"
 version_pattern = "MAJOR.MINOR.PATCH"
 commit_message = "bump version {old_version} -> {new_version}"
 commit = false

tests/midi/test_structures.py

@@ -87,14 +87,16 @@ def test_midi_piece_duration_calculation(sample_df):
 
 
 def test_trim_out_of_bounds(sample_midi_piece):
-    with pytest.raises(IndexError):
-        _ = sample_midi_piece.trim(5.5, 8)  # Out of bounds, should raise an error
+    # Out of bounds, should return empty piece
+    piece = sample_midi_piece.trim(5.5, 8)
+    assert piece.df.empty
 
 
 def test_trim_with_invalid_range(sample_midi_piece):
-    # Assuming the behavior is to raise an error with invalid range
-    with pytest.raises(IndexError):
-        _ = sample_midi_piece.trim(4, 2)  # Invalid range, start is greater than finish
+    # Invalid range, start is greater than finish
+    # Should return empty piece
+    piece = sample_midi_piece.trim(4, 2)
+    assert piece.df.empty
 
 
 def test_to_midi(sample_midi_piece):