chore: Always build an optimized nss (#3094)

* chore: Always build an optimized nss

And always use all cores to do so.

* Update neqo-crypto/build.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Lars Eggert <lars@eggert.org>

* Update .github/actions/nss/action.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Lars Eggert <lars@eggert.org>

---------

Signed-off-by: Lars Eggert <lars@eggert.org>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: 2 people

build.rs

@@ -153,24 +153,18 @@ fn get_bash() -> PathBuf {
     )
 }
 
-fn build_nss(dir: PathBuf, nsstarget: &str) {
+fn build_nss(dir: PathBuf) {
     let mut build_nss = vec![
         String::from("./build.sh"),
         String::from("-Ddisable_tests=1"),
         String::from("-Ddisable_dbm=1"),
         String::from("-Ddisable_libpkix=1"),
         String::from("-Ddisable_ckbi=1"),
         String::from("-Ddisable_fips=1"),
+        String::from("--opt"),
         // Generate static libraries in addition to shared libraries.
         String::from("--static"),
     ];
-    if nsstarget == "Release" {
-        build_nss.push(String::from("-o"));
-    }
-    if let Ok(d) = env::var("NSS_JOBS") {
-        build_nss.push(String::from("-j"));
-        build_nss.push(d);
-    }
     let target = env::var("TARGET").unwrap();
     if target.strip_prefix("aarch64-").is_some() {
         build_nss.push(String::from("--target=arm64"));
@@ -404,19 +398,14 @@ fn setup_standalone(nss_dir: String) -> Vec<String> {
     // $NSS_DIR/../dist/
     let nssdist = nss.parent().unwrap().join("dist");
     println!("cargo:rerun-if-env-changed={}", nssdist.display());
+    let nsstarget = "Release";
 
     // If NSS_PREBUILT is set, we assume that the NSS libraries are already built.
-    let nsstarget;
     if env::var("NSS_PREBUILT").is_err() {
-        // If NSS is not already built, we can't read the build mode of the last build
-        nsstarget = env::var("NSS_TARGET").unwrap_or_else(|_| String::from("Release"));
-        build_nss(nss, &nsstarget);
-    } else {
-        nsstarget = env::var("NSS_TARGET")
-            .unwrap_or_else(|_| fs::read_to_string(nssdist.join("latest")).unwrap());
+        build_nss(nss);
     }
-    let nsstarget = nssdist.join(nsstarget.trim());
 
+    let nsstarget = nssdist.join(nsstarget);
     let includes = get_includes(&nsstarget, &nssdist);
 
     let nsslibdir = nsstarget.join("lib");