Additional language support

[itpropro]

🏷️ Feature Type

New languages

🔖 Feature description

I saw that there are some changes going on currently with the lsp integration.
I wanted to add vue support (volar and ts_ls wit the vue plugin) in my own config and then contribute it here.
What would be the best way to go here currently? vim.lsp.enable?

[NotAShelf]

For personal use, vim.lsp is perfectly suitable. It's designed to leverage the new API in 0.11 to configure the LSP with Nix easily. If you are interested in also contributing the new LSP back as a langage module, then you're welcome to open a PR and add it to nvf :)

[itpropro]

I am still fighting with getting it to work, but I saw that the built-in languages didn't use the vim.lsp syntax. I just wanted to ask so I don't have to change a lot when contributing back.
Currently I am just having a hard time getting custom lsps to attach, but I probably just have to try around until I have some config that works.

[yashranjan1]

hey, have you been able to find a solution for this? ive been struggling as well...

[itpropro]

hey, have you been able to find a solution for this? ive been struggling as well...

Yes, I have implemented everything that I needed for vue with nvf. Adding new lsps from lspconfig is pretty easy actually:

lsp = {
  lspconfig = {
    enable = true;
    sources = {
      vue_ls = ''
        vim.lsp.enable('vue_ls')
        vim.lsp.config('vue_ls', {})
      '';
      eslint = ''
        vim.lsp.enable('eslint')
        vim.lsp.config('eslint', {})
      '';
      ts_ls = ''
        vim.lsp.enable('ts_ls')
        vim.lsp.config('ts_ls', {
          init_options = {
            plugins = {
              {
                name = "@vue/typescript-plugin",
                location = "${pkgs.vue-language-server}/lib/node_modules/@vue/language-server",
                languages = {"vue"},
              },
            },
          },
          filetypes = {
            "javascript",
            "typescript",
            "vue",
          },
        })
      '';
    };
  };
};

This is my config with eslint. I am not using prettier, but using eslint as formatter as well, so I also disabled prettier in the conform-nvim formatter config in nvf.

I am using home manager, so I also added these 3 language servers to the home.packages part of my nvf module:

typescript-language-server
vscode-langservers-extracted
vue-language-server

[freexploit]

These examples should be on the documentation.

[yashranjan1]

Thank you so much!

[horriblename]

with the new vim.lsp.servers api the following is recommended

vim.lsp.servers = {
  yamlls = {
    cmd = [(lib.getExe pkgs.yaml-language-server) "--stdio"];
    settings = {...} ;
  };
} 

see options docs for details on vim.lsp.servers

[itpropro]

with the new vim.lsp.servers api the following is recommended

vim.lsp.servers = {
  yamlls = {
    cmd = [(lib.getExe pkgs.yaml-language-server) "--stdio"];
    settings = {...} ;
  };
} 

see options docs for details on vim.lsp.servers

Is this only referring to the home.packages part?

[horriblename]

I'm not really sure what you're talking about with home.packages

lsp = {
  lspconfig = {
    enable = true;
    sources = {
      vue_ls = ''
        vim.lsp.enable('vue_ls')
        vim.lsp.config('vue_ls', {})
      '';
      ...
    };
  };
};

i was referring to this part. vim.lsp.servers maps one to one with the lua vim.lsp.config API (with the addition of an enable option). So you don't have to write the lua code by hand.

this is the updated code:

vim.lsp.servers = {
  vue_ls = {};
};

vim.lsp.lspconfig.sources is the old way of configuring via lspconfig and we'll probably remove/deprecate at some point in the future

[itpropro]

My question was about the language server, as you are still lacking the language server in your example. Many of the languages in the lspconfig repo need the lsp to be installed separately (especially on nixos), so I thought there would be an easier way to handle the lsp packages.

[itpropro]

It can't be migrated to lsp.servers @horriblename, as there is currently no init_options.

[horriblename]

My question was about the language server, as you are still lacking the language server in your example. Many of the languages in the lspconfig repo need the lsp to be installed separately (especially on nixos), so I thought there would be an easier way to handle the lsp packages.

there isn't at the moment. We decided to stick closer to the lua API so as to reduce discrepancy between nvf options and the lua API it abstracts, and to reduce the confusion that comes with having many ways to do the same thing. It is somewhat annoying to have to copy the args in order to change the command to a nix package, but the main problem I see with a package option is that, we might not know, in nix eval time, what the cmd arguments are, so we might end up writing something like this:

vim.lsp.servers.ts_ls = {
  cmd = mkLuaInline ''
    { "${getExe pkgs.ts-ls}", unpack(vim.lsp.config.ts_ls.cmd, 2) }
  '';
};

which is...ugly at best, and at worst there's probably some edge case where this doesn't work

EDIT: vim.lsp.config.ts_ls.cmd can be a lua function, so this definitely does not work. All of this to say, adding a package option to vim.lsp.servers.* does not look feasible at the moment

It can't be migrated to lsp.servers @horriblename, as there is currently no init_options.

as NotAShelf has answered in #981, vim.lsp.servers.* is a freeform module and can accept keys not defined by nvf itself

[itpropro]

Is there a reference for vtsls and vue? I got ts_ls to work with the vue plugin without a problem, but I need to switch to vtsls for performance reasons and vtsls is the only supported ts lsp for vue_lsp from v3 onwards.

[yashranjan1]

heres's how i got it to work

vim.lsp = {
  null-ls.enable = true;
  formatOnSave = true;
  servers = {
    vue_ls = { };
    vtsls = { };
    # other servers
  };
};

also put this in your vim.extraPackages

vue-language-server
vtsls

[yashranjan1]

from what i can tell you can use any lsp available in nvim-lspconfig using the vim.lsp.servers configuration, just stick the name of the lsp and leave an empty attribute set in front of it and it should work with its default settings

[itpropro]

I have it like that with all the configs documented in the vue language tools repo for neovim and the lsp loads, but there is no definitions, references, etc. available like it was with ts_ls.
The official guide requires setting up the vue plugin, on_init hook and more (https://github.com/vuejs/language-tools/wiki/Neovim).

[yashranjan1]

oh yeah i dont have that setup either, mb 👍

[badiwidya]

heres's how i got it to work

vim.lsp = {
  null-ls.enable = true;
  formatOnSave = true;
  servers = {
    vue_ls = { };
    vtsls = { };
    # other servers
  };
};

also put this in your vim.extraPackages

vue-language-server
vtsls

is using this setup also add blink-cmp capabilities automatically?