qol

Author: NotValra

src/background/background.js

@@ -85,7 +85,8 @@ function getDefaultSettings() {
         totalearnedEnabled: true,
         EnableRobloxApiDocs: false,
         QuickOutfitsEnabled: false,
-        gameTitleIssueEnable: true
+        gameTitleIssueEnable: true,
+        closeUiByClickingTheBackground:  true
     };
 }
 

src/content/core/settings/settingConfig.js

@@ -119,6 +119,12 @@ export const SETTINGS_CONFIG = {
                         ],
                         type: "checkbox",
                         default: true
+                    },
+                    closeUiByClickingTheBackground: {
+                        label: "Close the 'What am I joining' UI by clicking the background",
+                        description: "This allows you to click the background to close the UI, can be annoying if you want to see the info provided in the UI",
+                        type: "checkbox",
+                        default: true
                     }
                 }
             },

src/content/core/ui/startModal/gamelaunchmodal.js

@@ -184,7 +184,7 @@ try {
 let activeInstance = null;
 let keepOverlayOpen = false;
 
-export function showLoadingOverlay(onCancel, customLogo = null) {
+export function showLoadingOverlay(onCancel, customLogo = null, closeOnBackgroundClick = false) {
     keepOverlayOpen = false;
 
     if (activeInstance) {
@@ -241,7 +241,13 @@ export function showLoadingOverlay(onCancel, customLogo = null) {
 
     const { overlay, close } = createOverlay({
         title: '', bodyContent: bodyWrapper, showLogo: false,
-        maxWidth: '350px', preventBackdropClose: true
+        maxWidth: '350px', preventBackdropClose: !closeOnBackgroundClick,
+        onClose: () => {
+            if (activeInstance) {
+                activeInstance = null;
+                if (typeof onCancel === 'function') onCancel();
+            }
+        }
     });
 
     const titleEl = overlay.querySelector('.group-description-dialog-body-header');
@@ -264,8 +270,9 @@ export function hideLoadingOverlay(force = false) {
     if (keepOverlayOpen && !force) return;
 
     if (activeInstance) {
-        activeInstance.close();
+        const instance = activeInstance;
         activeInstance = null;
+        instance.close();
     }
 }
 

src/content/features/games/revertlogo.js

@@ -46,12 +46,12 @@ try {
 } catch(e) { }
 
 
-function openInterface(onCancel, customLogo) {
+function openInterface(onCancel, customLogo, closeOnBackgroundClick) {
     document.body.classList.add(HIDE_ROBLOX_UI_CLASS);
     showLoadingOverlay(() => {
         closeInterface();
         if (onCancel) onCancel();
-    }, customLogo);
+    }, customLogo, closeOnBackgroundClick);
 }
 
 function closeInterface(force = false) {
@@ -432,7 +432,7 @@ function initializeJoinDialogEnhancer() {
         }
     });
 
-    chrome.storage.local.get({ whatamIJoiningEnabled: true, AlwaysGetInfo: false, customLogoData: null, revertLogo: false }, (settings) => {
+    chrome.storage.local.get({ whatamIJoiningEnabled: true, AlwaysGetInfo: false, customLogoData: null, revertLogo: false, closeUiByClickingTheBackground: true }, (settings) => {
 
         const processGameLaunchData = async (gameLaunchFrame) => {
             gameLaunchElementExists = true;
@@ -446,7 +446,7 @@ function initializeJoinDialogEnhancer() {
 
             const logoToUse = (settings.revertLogo === true && settings.customLogoData) ? settings.customLogoData : null;
 
-            openInterface(null, logoToUse);
+            openInterface(null, logoToUse, settings.closeUiByClickingTheBackground);
 
             let urlParams;
             let placeId;