Summary
NETWORKS.mainnet points at a specific commercial RPC provider's URL. Anyone
calling getNetwork("mainnet") silently routes their traffic through that
provider, with whatever rate limits and availability it happens to have, and
without having chosen it.
networkFromEnv already exists as the override, so the fix is mostly about not
making the surprising choice the default.
Acceptance criteria
Getting started
Fork this repository, clone your fork, and add this repo as upstream:
git clone https://github.com/<your-username>/novatip-sdk.git
cd novatip-sdk
git remote add upstream https://github.com/Novatip/novatip-sdk.git
npm install
Create a branch for this issue:
git checkout -b fix/mainnet-rpc-default
Suggested commit message:
fix: reconsider the hardcoded mainnet RPC
Run npm run lint, npm run typecheck, and npm run build before pushing, then open a pull request from your fork against main and link this issue. See the contributing guide for the full workflow.
Summary
NETWORKS.mainnetpoints at a specific commercial RPC provider's URL. Anyonecalling
getNetwork("mainnet")silently routes their traffic through thatprovider, with whatever rate limits and availability it happens to have, and
without having chosen it.
networkFromEnvalready exists as the override, so the fix is mostly about notmaking the surprising choice the default.
Acceptance criteria
provider prominently at the point of use.
controls.
Getting started
Fork this repository, clone your fork, and add this repo as
upstream:Create a branch for this issue:
Suggested commit message:
Run
npm run lint,npm run typecheck, andnpm run buildbefore pushing, then open a pull request from your fork againstmainand link this issue. See the contributing guide for the full workflow.