Merge pull request #2356 from TrimmingFool/jest-tests

move httprpc response methods to js/rtorrent.js and add jest tests

Author: Novik

js/rtorrent.js

@@ -105,16 +105,14 @@ rTorrentStub.prototype.getchunks = function()
 	}
 }
 
-rTorrentStub.prototype.getchunksResponse = function(xml) 
+rTorrentStub.prototype.getchunksParseXML = function(xml)
 {
 	if(plugin.hash!=theWebUI.dID)
-	        return({});
-	var datas = xml.getElementsByTagName('data');
-	var data = datas[0];
-	var values = data.getElementsByTagName('value');
-	var ret = { chunks: this.getValue(values,1), size: this.getValue(values,3), tsize: this.getValue(values,5) }
+		return({});
+	const values = this.getXMLValues(xml, 2, 1)[0];
+	var ret = { chunks: values[0], size: values[1], tsize: values[2] }
 	if(theWebUI.systemInfo.rTorrent.apiVersion>=4)
-		ret.seen = this.getValue(values,7);
+		ret.seen = values[3];
 	return(ret);
 }
 
@@ -164,4 +162,4 @@ plugin.onLangLoaded = function()
 plugin.onRemove = function()
 {
 	plugin.removePageFromTabs("Chunks");
-}
+}

plugins/chunks/init.js

@@ -56,7 +56,7 @@ rTorrentStub.prototype.getsavepathResponse = function( xml )
 	var save_path = '';
 	if(torrent)
 	{
-		torrent.base_path = this.getValue( values, 3 );
+		torrent.base_path = this.getXMLValue( values, 3 );
 		var pos = torrent.base_path.lastIndexOf('/');
 		torrent.save_path = (torrent.base_path.substring(pos+1) === torrent.name) ? 
 			torrent.base_path.substring(0,pos) : torrent.base_path;