Backport of plimits plugin for ruTorrent v4.0

[mrlongshen]

Please complete the following tasks.

• Web browser cache cleared
• Copied everything if upgrading to v4.0 or master
• Web browser, ruTorrent and PHP version provided

Tell us about your environment

Mozilla Firefox Latest
4.0
7.2

Give us detailed steps to reproduce the error

SyntaxError: Unexpected token '<'

Tell us the error message

When I put this plimit plugins, and then reload my rtorrent, the rutorrent will crash. and give error message SyntaxError: Unexpected token '<'

When using rutorrent version 3.10 no error and working perfectly.

Provide the php error log contents (if applicable)

No response

[stickz]

@mrlongshen Please provide the source files to the Plimits plugin. Zip the folder and attach it to GitHub.

[mrlongshen]

@mrlongshen Please provide the source files to the Plimits plugin. Zip the folder and attach it to GitHub.

Hi.
This is the plugins.
https://mega.nz/file/PUhi2IwB#TmpQNw8jV9tPUER4P-4p3NIxM5pepqBOQvFr9xoJVpg
Long time ago build by Novik

Can you fix it to work on rutorrent 4.0 ?

[stickz]

Can you fix it to work on rutorrent 4.0 ?

I will let you know, once I get a response from @Novik about why this plugin is not distributed with ruTorrent. And hear his thoughts about fixing it up and distributing it as an integrated or third party plugin.

[stickz]

Looking at the code quality and intended purpose, it looks like this would be better as a third party plugin. If Novik wants to create a new GitHub repository for this plugin, I can easily fix it up to work with ruTorrent version 4.0.

This is not something I would distribute directly with ruTorrent or an install script. While it is sensible to for such a feature to be usable, the plugin is not good enough shape to integrate. The user would need to manually install it on their own.

[mrlongshen]

Looking at the code quality and intended purpose, it looks like this would be better as a third party plugin. If Novik wants to create a new GitHub repository for this plugin, I can easily fix it up to work with ruTorrent version 4.0.

This is not something I would distribute directly with ruTorrent or an install script. While it is sensible to for such a feature to be usable, the plugin is not good enough shape to integrate. The user would need to manually install it on their own.

I'm agree with you if this plugin as the third party plugin as an optional for user to use it. It may useful for some user. As this plugin is develop by Novik itself, I hope this plugin can be maintained like normal plugin. Please don't abandon it.

[Micdu70]

Hello there! :)

Here's my fork of the Plimits plugin for ruTorrent v4.0 => https://github.com/Micdu70/rutorrent-plimits

;)

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.