refactor: reduce complexity (#27)

By using separate methods we make use of method naming to make it clearer what the actions and intentions are.

Author: Joris Conijn

Makefile

@@ -33,7 +33,7 @@ release: build
 
 complexity-baseline:
 	$(info Maintenability index)
-	radon mi --min A --max A --show report2junit
+	radon mi --min A --max A --show --sort report2junit
 	$(info Cyclomatic complexity index)
 	xenon --max-absolute A --max-modules A --max-average A report2junit
 

report2junit/reports/cfn_nag.py

@@ -19,18 +19,23 @@ def compatible(cls, data: bytes) -> bool:
         return "filename" in entry and "file_results" in entry
 
     def __create_report(self) -> TestSuite:
-        source = self.parse(self.source)
+        list(self.__findings())
+        return TestSuite("cfn-nag findings", self.cases)
 
-        for file_findings in source:
-            for violation in file_findings["file_results"]["violations"]:
-                for i, resource_id in enumerate(violation["logical_resource_ids"]):
-                    self.failure(
-                        name=f"{violation['id']} - {violation['message']}",
-                        message=f"{file_findings['filename']}#L{violation['line_numbers'][i]}",
-                        classname=resource_id,
-                    )
+    def __findings(self) -> map:
+        return map(self.__parse_findings, self.parse(self.source))
 
-        return TestSuite("cfn-nag findings", self.cases)
+    def __parse_findings(self, file_finding: dict) -> None:
+        for violation in file_finding["file_results"]["violations"]:
+            self.__parse_violation(file_finding["filename"], violation)
+
+    def __parse_violation(self, file_name: str, violation) -> None:
+        for index, resource_id in enumerate(violation["logical_resource_ids"]):
+            self.failure(
+                name=f"{violation['id']} - {violation['message']}",
+                message=f"{file_name}#L{violation['line_numbers'][index]}",
+                classname=resource_id,
+            )
 
     def apply(self, callback: Callable[[TestSuite], None]) -> bool:
         callback(self.__create_report())